Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: Source/core/rendering/RenderInline.h

Issue 899163003: Move rendering/RenderObject to layout/LayoutObject. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderImageResourceStyleImage.cpp ('k') | Source/core/rendering/RenderInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderInline.h
diff --git a/Source/core/rendering/RenderInline.h b/Source/core/rendering/RenderInline.h
index 2984b6071bb1d6bc4e39b9c96f5384345aea44de..3ce3c9b0ae51a6dca103ac8f32c4e7c5cb4f5f1d 100644
--- a/Source/core/rendering/RenderInline.h
+++ b/Source/core/rendering/RenderInline.h
@@ -36,14 +36,14 @@ public:
static RenderInline* createAnonymous(Document*);
- RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
- RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }
+ LayoutObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
+ LayoutObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }
// If you have a RenderInline, use firstChild or lastChild instead.
void slowFirstChild() const = delete;
void slowLastChild() const = delete;
- virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override;
+ virtual void addChild(LayoutObject* newChild, LayoutObject* beforeChild = 0) override;
Element* node() const { return toElement(RenderBoxModelObject::node()); }
@@ -60,7 +60,7 @@ public:
virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const override final;
virtual void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
- virtual LayoutSize offsetFromContainer(const RenderObject*, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override final;
+ virtual LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override final;
IntRect linesBoundingBox() const;
LayoutRect linesVisualOverflowBoundingBox() const;
@@ -107,10 +107,10 @@ protected:
virtual void invalidateDisplayItemClients(DisplayItemList*) const override;
private:
- virtual RenderObjectChildList* virtualChildren() override final { return children(); }
- virtual const RenderObjectChildList* virtualChildren() const override final { return children(); }
- const RenderObjectChildList* children() const { return &m_children; }
- RenderObjectChildList* children() { return &m_children; }
+ virtual LayoutObjectChildList* virtualChildren() override final { return children(); }
+ virtual const LayoutObjectChildList* virtualChildren() const override final { return children(); }
+ const LayoutObjectChildList* children() const { return &m_children; }
+ LayoutObjectChildList* children() { return &m_children; }
virtual const char* renderName() const override;
@@ -125,15 +125,15 @@ private:
template<typename GeneratorContext>
void generateCulledLineBoxRects(GeneratorContext& yield, const RenderInline* container) const;
- void addChildToContinuation(RenderObject* newChild, RenderObject* beforeChild);
- virtual void addChildIgnoringContinuation(RenderObject* newChild, RenderObject* beforeChild = 0) override final;
+ void addChildToContinuation(LayoutObject* newChild, LayoutObject* beforeChild);
+ virtual void addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* beforeChild = 0) override final;
- void moveChildrenToIgnoringContinuation(RenderInline* to, RenderObject* startChild);
+ void moveChildrenToIgnoringContinuation(RenderInline* to, LayoutObject* startChild);
void splitInlines(RenderBlock* fromBlock, RenderBlock* toBlock, RenderBlock* middleBlock,
- RenderObject* beforeChild, RenderBoxModelObject* oldCont);
- void splitFlow(RenderObject* beforeChild, RenderBlock* newBlockBox,
- RenderObject* newChild, RenderBoxModelObject* oldCont);
+ LayoutObject* beforeChild, RenderBoxModelObject* oldCont);
+ void splitFlow(LayoutObject* beforeChild, RenderBlock* newBlockBox,
+ LayoutObject* newChild, RenderBoxModelObject* oldCont);
virtual void layout() override final { ASSERT_NOT_REACHED(); } // Do nothing for layout()
@@ -169,12 +169,12 @@ private:
virtual InlineFlowBox* createInlineFlowBox(); // Subclassed by SVG and Ruby
- virtual void dirtyLinesFromChangedChild(RenderObject* child) override final { m_lineBoxes.dirtyLinesFromChangedChild(this, child); }
+ virtual void dirtyLinesFromChangedChild(LayoutObject* child) override final { m_lineBoxes.dirtyLinesFromChangedChild(this, child); }
virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override final;
virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override final;
- virtual void childBecameNonInline(RenderObject* child) override final;
+ virtual void childBecameNonInline(LayoutObject* child) override final;
virtual void updateHitTestResult(HitTestResult&, const LayoutPoint&) override final;
@@ -186,13 +186,13 @@ private:
RenderInline* clone() const;
- RenderBoxModelObject* continuationBefore(RenderObject* beforeChild);
+ RenderBoxModelObject* continuationBefore(LayoutObject* beforeChild);
- RenderObjectChildList m_children;
+ LayoutObjectChildList m_children;
RenderLineBoxList m_lineBoxes; // All of the line boxes created for this inline flow. For example, <i>Hello<br>world.</i> will have two <i> line boxes.
};
-DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderInline, isRenderInline());
+DEFINE_LAYOUT_OBJECT_TYPE_CASTS(RenderInline, isRenderInline());
} // namespace blink
« no previous file with comments | « Source/core/rendering/RenderImageResourceStyleImage.cpp ('k') | Source/core/rendering/RenderInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698