Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: Source/core/dom/RenderTreeBuilder.h

Issue 899163003: Move rendering/RenderObject to layout/LayoutObject. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 13 matching lines...) Expand all
24 */ 24 */
25 25
26 #ifndef RenderTreeBuilder_h 26 #ifndef RenderTreeBuilder_h
27 #define RenderTreeBuilder_h 27 #define RenderTreeBuilder_h
28 28
29 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
30 #include "core/dom/FirstLetterPseudoElement.h" 30 #include "core/dom/FirstLetterPseudoElement.h"
31 #include "core/dom/Node.h" 31 #include "core/dom/Node.h"
32 #include "core/dom/NodeRenderingTraversal.h" 32 #include "core/dom/NodeRenderingTraversal.h"
33 #include "core/dom/Text.h" 33 #include "core/dom/Text.h"
34 #include "core/rendering/RenderObject.h" 34 #include "core/layout/LayoutObject.h"
35 #include "wtf/RefPtr.h" 35 #include "wtf/RefPtr.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class RenderObject; 39 class LayoutObject;
40 class RenderStyle; 40 class RenderStyle;
41 41
42 template <typename NodeType> 42 template <typename NodeType>
43 class RenderTreeBuilder { 43 class RenderTreeBuilder {
44 STACK_ALLOCATED(); 44 STACK_ALLOCATED();
45 protected: 45 protected:
46 RenderTreeBuilder(NodeType& node, RenderObject* renderingParent) 46 RenderTreeBuilder(NodeType& node, LayoutObject* renderingParent)
47 : m_node(node) 47 : m_node(node)
48 , m_renderingParent(renderingParent) 48 , m_renderingParent(renderingParent)
49 { 49 {
50 ASSERT(!node.renderer()); 50 ASSERT(!node.renderer());
51 ASSERT(node.needsAttach()); 51 ASSERT(node.needsAttach());
52 ASSERT(node.document().inStyleRecalc()); 52 ASSERT(node.document().inStyleRecalc());
53 53
54 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called 54 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called
55 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations 55 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
56 // will trigger a layout inside childrenChanged. 56 // will trigger a layout inside childrenChanged.
57 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange 57 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange
58 // which does an updateLayoutIgnorePendingStylesheets. 58 // which does an updateLayoutIgnorePendingStylesheets.
59 } 59 }
60 60
61 RenderObject* parentRenderer() const { return m_renderingParent; } 61 LayoutObject* parentRenderer() const { return m_renderingParent; }
62 62
63 RenderObject* nextRenderer() const 63 LayoutObject* nextRenderer() const
64 { 64 {
65 ASSERT(m_renderingParent); 65 ASSERT(m_renderingParent);
66 66
67 // Avoid an O(N^2) walk over the children when reattaching all children of a node. 67 // Avoid an O(N^2) walk over the children when reattaching all children of a node.
68 if (m_renderingParent->node() && m_renderingParent->node()->needsAttach( )) 68 if (m_renderingParent->node() && m_renderingParent->node()->needsAttach( ))
69 return 0; 69 return 0;
70 70
71 return NodeRenderingTraversal::nextSiblingRenderer(*m_node); 71 return NodeRenderingTraversal::nextSiblingRenderer(*m_node);
72 } 72 }
73 73
74 RawPtrWillBeMember<NodeType> m_node; 74 RawPtrWillBeMember<NodeType> m_node;
75 RawPtrWillBeMember<RenderObject> m_renderingParent; 75 RawPtrWillBeMember<LayoutObject> m_renderingParent;
76 }; 76 };
77 77
78 class RenderTreeBuilderForElement : public RenderTreeBuilder<Element> { 78 class RenderTreeBuilderForElement : public RenderTreeBuilder<Element> {
79 public: 79 public:
80 RenderTreeBuilderForElement(Element&, RenderStyle*); 80 RenderTreeBuilderForElement(Element&, RenderStyle*);
81 81
82 void createRendererIfNeeded() 82 void createRendererIfNeeded()
83 { 83 {
84 if (shouldCreateRenderer()) 84 if (shouldCreateRenderer())
85 createRenderer(); 85 createRenderer();
86 } 86 }
87 87
88 private: 88 private:
89 RenderObject* parentRenderer() const; 89 LayoutObject* parentRenderer() const;
90 RenderObject* nextRenderer() const; 90 LayoutObject* nextRenderer() const;
91 bool shouldCreateRenderer() const; 91 bool shouldCreateRenderer() const;
92 RenderStyle& style() const; 92 RenderStyle& style() const;
93 void createRenderer(); 93 void createRenderer();
94 94
95 mutable RefPtr<RenderStyle> m_style; 95 mutable RefPtr<RenderStyle> m_style;
96 }; 96 };
97 97
98 class RenderTreeBuilderForText : public RenderTreeBuilder<Text> { 98 class RenderTreeBuilderForText : public RenderTreeBuilder<Text> {
99 public: 99 public:
100 RenderTreeBuilderForText(Text& text, RenderObject* renderingParent) 100 RenderTreeBuilderForText(Text& text, LayoutObject* renderingParent)
101 : RenderTreeBuilder(text, renderingParent) { } 101 : RenderTreeBuilder(text, renderingParent) { }
102 102
103 void createRenderer(); 103 void createRenderer();
104 }; 104 };
105 105
106 } // namespace blink 106 } // namespace blink
107 107
108 #endif 108 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698