Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 899133002: Adds src to the list of attributes known for iframes (Closed)

Created:
5 years, 10 months ago by sky
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds src to the list of attributes known for iframes This way I stop getting warnings about an unknown attribute. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5730a33a8a3d87f272b120583276aa79371750b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/framework/sky-element/element-registry.sky View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
5 years, 10 months ago (2015-02-04 23:27:58 UTC) #1
hansmuller1
On 2015/02/04 23:27:58, sky wrote: Hooray!
5 years, 10 months ago (2015-02-04 23:28:47 UTC) #2
esprehn
lgtm
5 years, 10 months ago (2015-02-04 23:30:26 UTC) #3
sky
5 years, 10 months ago (2015-02-04 23:39:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5730a33a8a3d87f272b120583276aa79371750b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698