Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2413)

Unified Diff: content/shell/app/shell_main_delegate.cc

Issue 899103002: Chromium-side patch to rename "--dump-render-tree" to "--run-layout-test". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/app/shell_main_delegate.cc
diff --git a/content/shell/app/shell_main_delegate.cc b/content/shell/app/shell_main_delegate.cc
index de0b758572eae54ac63684597f6f4f9debecd421..5c10679aa7ba72bd6ef338798a03b378b92cae37 100644
--- a/content/shell/app/shell_main_delegate.cc
+++ b/content/shell/app/shell_main_delegate.cc
@@ -141,7 +141,13 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
}
}
- if (command_line.HasSwitch(switches::kDumpRenderTree)) {
+ // "dump-render-tree" has been renamed to "run-layout-test", but the old
+ // flag name is still used in some places, so this check will remain until
+ // it is phased out entirely.
+ if (command_line.HasSwitch(switches::kDumpRenderTree))
+ command_line.AppendSwitch(switches::kRunLayoutTest);
+
+ if (command_line.HasSwitch(switches::kRunLayoutTest)) {
EnableBrowserLayoutTestMode();
command_line.AppendSwitch(switches::kProcessPerTab);
@@ -262,7 +268,7 @@ int ShellMainDelegate::RunProcess(
browser_runner_.reset(BrowserMainRunner::Create());
base::CommandLine& command_line = *base::CommandLine::ForCurrentProcess();
- return command_line.HasSwitch(switches::kDumpRenderTree) ||
+ return command_line.HasSwitch(switches::kRunLayoutTest) ||
command_line.HasSwitch(switches::kCheckLayoutTestSysDeps)
? LayoutTestBrowserMain(main_function_params, browser_runner_)
: ShellBrowserMain(main_function_params, browser_runner_);
@@ -318,7 +324,7 @@ void ShellMainDelegate::InitializeResourceBundle() {
ContentBrowserClient* ShellMainDelegate::CreateContentBrowserClient() {
browser_client_.reset(base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDumpRenderTree)
+ switches::kRunLayoutTest)
? new LayoutTestContentBrowserClient
: new ShellContentBrowserClient);
@@ -327,7 +333,7 @@ ContentBrowserClient* ShellMainDelegate::CreateContentBrowserClient() {
ContentRendererClient* ShellMainDelegate::CreateContentRendererClient() {
renderer_client_.reset(base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDumpRenderTree)
+ switches::kRunLayoutTest)
? new LayoutTestContentRendererClient
: new ShellContentRendererClient);

Powered by Google App Engine
This is Rietveld 408576698