Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 899073003: Make Reflector Use Main Thread MessageLoop when in SingleThread (Closed)

Created:
5 years, 10 months ago by weiliangc
Modified:
5 years, 10 months ago
Reviewers:
danakj
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, enne (OOO), jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@turnitoff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Reflector Use Main Thread MessageLoop when in SingleThread When in using single thread with browser compositor, make reflector use main thread MessageLoop instead. Test with forced SW mirrored display on both Linux-cros build and Pixel. BUG=453732 Committed: https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1 Cr-Commit-Position: refs/heads/master@{#314665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M content/browser/compositor/reflector_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 3 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
weiliangc
5 years, 10 months ago (2015-02-04 21:31:40 UTC) #2
danakj
LGTM
5 years, 10 months ago (2015-02-04 21:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899073003/1
5 years, 10 months ago (2015-02-04 21:38:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 22:44:41 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1 Cr-Commit-Position: refs/heads/master@{#314665}
5 years, 10 months ago (2015-02-04 22:46:30 UTC) #7
dcheng
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/900133002/ by dcheng@chromium.org. ...
5 years, 10 months ago (2015-02-05 03:14:36 UTC) #8
oshima
5 years, 10 months ago (2015-02-05 04:03:06 UTC) #9
Message was sent while issue was closed.
On 2015/02/05 03:14:36, dcheng wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/900133002/ by mailto:dcheng@chromium.org.
> 
> The reason for reverting is: Reason for revert:
> Speculatively reverting to try to fix broken Mac 10.8 retina layout tests in
> Blink:
> compositing/iframes/iframe-composited-scrolling-hide-and-show.html
> compositing/iframes/overlapped-iframe-iframe.html
> svg/as-border-image/svg-as-border-image-2.html
> and more..

This is used only on chromeos, so the issue is most likely somewhere else.

Powered by Google App Engine
This is Rietveld 408576698