Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 899063002: Fix comment describing how to use finalize_apk_action.gypi (Closed)

Created:
5 years, 10 months ago by mstrum
Modified:
5 years, 10 months ago
Reviewers:
cjhopman, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix comment describing how to use finalize_apk_action.gypi The existing comment references the old name of finalize_apk_action.gypi, this updates it to its current name. This also reorders the input list to be alphabetized. Committed: https://crrev.com/81d5159b4693364739934f8bd698711cd5eca715 Cr-Commit-Position: refs/heads/master@{#314656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/finalize_apk_action.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstrum
PTAL
5 years, 10 months ago (2015-02-04 19:04:13 UTC) #2
jbudorick
+cjhopman
5 years, 10 months ago (2015-02-04 19:27:40 UTC) #4
cjhopman
lgtm
5 years, 10 months ago (2015-02-04 20:15:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899063002/1
5 years, 10 months ago (2015-02-04 20:21:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 22:15:23 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 22:17:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81d5159b4693364739934f8bd698711cd5eca715
Cr-Commit-Position: refs/heads/master@{#314656}

Powered by Google App Engine
This is Rietveld 408576698