Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Issue 899003002: Fixing bad error return code in html5fs remove/unlink/rmdir. (Closed)

Created:
5 years, 10 months ago by bradn
Modified:
5 years, 10 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing bad error return code in html5fs remove/unlink/rmdir. Creating a FileRef does not check if the file exists or not. We had assumed that if a FileRef could be created that the file or directory in question exists. Instead look at the result code from Query and possibly return ENOENT if it turns out the file or diretory does not exist. BUG=None TEST=nacl_io_tests R=sbc@chromium.org Committed: https://crrev.com/c27b19192a297c1b81da98e728305d4a5009a081 Cr-Commit-Position: refs/heads/master@{#314582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bradn
5 years, 10 months ago (2015-02-04 16:53:52 UTC) #1
bradn
5 years, 10 months ago (2015-02-04 17:09:25 UTC) #3
Sam Clegg
lgtm
5 years, 10 months ago (2015-02-04 17:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899003002/1
5 years, 10 months ago (2015-02-04 17:43:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 18:06:53 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:07:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c27b19192a297c1b81da98e728305d4a5009a081
Cr-Commit-Position: refs/heads/master@{#314582}

Powered by Google App Engine
This is Rietveld 408576698