src/x64/assembler-x64.cc - Issue 898953003: [x64] Fix strict aliasing error with GCC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 898953003: [x64] Fix strict aliasing error with GCC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 597aa31f54d86c59d0cb5fe3dccae6334c716aa3..3ce420e3e7bdb8122f88a0c2d2f053d9ed092d8b 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -485,7 +485,7 @@ void Assembler::emit_operand(int code, const Operand& adr) {

// Recognize RIP relative addressing.

if (adr.buf_[0] == 5) {

DCHECK_EQ(9u, length);

- Label* label = *reinterpret_cast<Label* const*>(&adr.buf_[1]);

+ Label* label = *bit_cast<Label* const*>(&adr.buf_[1]);

if (label->is_bound()) {

int offset = label->pos() - pc_offset() - sizeof(int32_t);

DCHECK_GE(0, offset);

« no previous file with comments | « no previous file | no next file » | no next file with comments »