Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 898953003: [x64] Fix strict aliasing error with GCC. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix strict aliasing error with GCC. BUG=v8:3872 LOG=n R=dcarney@chromium.org Committed: https://crrev.com/693e633b5c704c5592222bf88420937041cd0e57 Cr-Commit-Position: refs/heads/master@{#26521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-09 10:23:43 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-09 10:23:59 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-09 10:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898953003/1
5 years, 10 months ago (2015-02-09 10:25:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 10:44:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 10:44:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/693e633b5c704c5592222bf88420937041cd0e57
Cr-Commit-Position: refs/heads/master@{#26521}

Powered by Google App Engine
This is Rietveld 408576698