Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898923002: Update histograms.xml to include V8.CodeCacheSizeRatio. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update histograms.xml to include V8.CodeCacheSizeRatio. Committed: https://crrev.com/5014115ae83784db81b57809e73f2b5f28d8e986 Cr-Commit-Position: refs/heads/master@{#314819}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
See: https://codereview.chromium.org/869513005/
5 years, 10 months ago (2015-02-04 13:15:04 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/898923002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/898923002/diff/1/tools/metrics/histograms/histograms.xml#newcode39920 tools/metrics/histograms/histograms.xml:39920: + <summary>Code cache size to source size ratio.</summary> Mention ...
5 years, 10 months ago (2015-02-04 14:36:42 UTC) #3
Yang
https://codereview.chromium.org/898923002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/898923002/diff/1/tools/metrics/histograms/histograms.xml#newcode39920 tools/metrics/histograms/histograms.xml:39920: + <summary>Code cache size to source size ratio.</summary> On ...
5 years, 10 months ago (2015-02-04 14:54:03 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-04 15:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898923002/20001
5 years, 10 months ago (2015-02-04 16:16:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/22858)
5 years, 10 months ago (2015-02-04 17:54:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898923002/20001
5 years, 10 months ago (2015-02-05 15:01:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 15:54:35 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 15:56:35 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5014115ae83784db81b57809e73f2b5f28d8e986
Cr-Commit-Position: refs/heads/master@{#314819}

Powered by Google App Engine
This is Rietveld 408576698