Issue 8989041: Revert 115214 (caused media_unittests failure in FFmpegGlueTest,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8989041: Revert 115214 (caused media_unittests failure in FFmpegGlueTest, (Closed)

Created:
9 years ago by dmazzoni

Modified:
9 years ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 115214 (caused media_unittests failure in FFmpegGlueTest, suspiciously immediately after the code modified in this test.) Fix ChunkDemuxer seeks that occur during a partially parsed cluster. BUG=104160 TEST=ChunkDemuxerTest.TestSeekWhileParsingCluster, WebMParserTest.TestReset Review URL: http://codereview.chromium.org/9010001 TBR=acolwell@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115229

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -158 lines)			Patch
M	media/base/byte_queue.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/base/byte_queue.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	media/filters/chunk_demuxer.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/filters/chunk_demuxer_unittest.cc	View	9 chunks	+29 lines, -92 lines	0 comments	Download
M	media/webm/webm_cluster_parser.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/webm/webm_cluster_parser.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	media/webm/webm_parser_unittest.cc	View	5 chunks	+4 lines, -44 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages