Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: Source/WebCore/rendering/RenderTableRow.cpp

Issue 8989014: Revert 99212 - Stop abusing RenderTableSection::needsRecalcCells logic (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/rendering/RenderTableRow.h ('k') | Source/WebCore/rendering/RenderTableSection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderTableRow.cpp
===================================================================
--- Source/WebCore/rendering/RenderTableRow.cpp (revision 103315)
+++ Source/WebCore/rendering/RenderTableRow.cpp (working copy)
@@ -53,6 +53,16 @@
recalcSection->setNeedsCellRecalc();
}
+void RenderTableRow::styleWillChange(StyleDifference diff, const RenderStyle* newStyle)
+{
+ if (section() && style() && style()->logicalHeight() != newStyle->logicalHeight())
+ section()->setNeedsCellRecalc();
+
+ ASSERT(newStyle->display() == TABLE_ROW);
+
+ RenderBox::styleWillChange(diff, newStyle);
+}
+
void RenderTableRow::updateBeforeAndAfterContent()
{
if (!isAnonymous() && document()->usesBeforeAfterRules()) {
@@ -63,17 +73,12 @@
void RenderTableRow::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
- ASSERT(style()->display() == TABLE_ROW);
-
RenderBox::styleDidChange(diff, oldStyle);
propagateStyleToAnonymousChildren();
if (parent())
updateBeforeAndAfterContent();
- if (section() && oldStyle && style()->logicalHeight() != oldStyle->logicalHeight())
- section()->rowLogicalHeightChanged(section()->rowIndexForRenderer(this));
-
// If border was changed, notify table.
if (parent()) {
RenderTable* table = this->table();
« no previous file with comments | « Source/WebCore/rendering/RenderTableRow.h ('k') | Source/WebCore/rendering/RenderTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698