Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: Source/WebCore/rendering/RenderTableSection.cpp

Issue 8989014: Revert 99212 - Stop abusing RenderTableSection::needsRecalcCells logic (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/rendering/RenderTableSection.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 RenderTableCell* tableCell = toRenderTableCell(cell); 1148 RenderTableCell* tableCell = toRenderTableCell(cell);
1149 addCell(tableCell, tableRow); 1149 addCell(tableCell, tableRow);
1150 } 1150 }
1151 } 1151 }
1152 } 1152 }
1153 1153
1154 m_grid.shrinkToFit(); 1154 m_grid.shrinkToFit();
1155 setNeedsLayout(true); 1155 setNeedsLayout(true);
1156 } 1156 }
1157 1157
1158 void RenderTableSection::rowLogicalHeightChanged(unsigned rowIndex)
1159 {
1160 setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative(m_grid[rowIndex]);
1161 }
1162
1163 void RenderTableSection::setNeedsCellRecalc() 1158 void RenderTableSection::setNeedsCellRecalc()
1164 { 1159 {
1165 m_needsCellRecalc = true; 1160 m_needsCellRecalc = true;
1166 if (RenderTable* t = table()) 1161 if (RenderTable* t = table())
1167 t->setNeedsSectionRecalc(); 1162 t->setNeedsSectionRecalc();
1168 } 1163 }
1169 1164
1170 unsigned RenderTableSection::numColumns() const 1165 unsigned RenderTableSection::numColumns() const
1171 { 1166 {
1172 unsigned result = 0; 1167 unsigned result = 0;
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 LayoutPoint cellPoint = flipForWritingModeForChild(cell, adjustedLocatio n); 1279 LayoutPoint cellPoint = flipForWritingModeForChild(cell, adjustedLocatio n);
1285 if (static_cast<RenderObject*>(cell)->nodeAtPoint(request, result, point InContainer, cellPoint, action)) { 1280 if (static_cast<RenderObject*>(cell)->nodeAtPoint(request, result, point InContainer, cellPoint, action)) {
1286 updateHitTestResult(result, toLayoutPoint(pointInContainer - cellPoi nt)); 1281 updateHitTestResult(result, toLayoutPoint(pointInContainer - cellPoi nt));
1287 return true; 1282 return true;
1288 } 1283 }
1289 } 1284 }
1290 return false; 1285 return false;
1291 1286
1292 } 1287 }
1293 1288
1294 unsigned RenderTableSection::rowIndexForRenderer(const RenderTableRow* row) cons t
1295 {
1296 for (size_t i = 0; i < m_grid.size(); ++i) {
1297 if (m_grid[i].rowRenderer == row)
1298 return i;
1299 }
1300 ASSERT_NOT_REACHED();
1301 return 0;
1302 }
1303
1304 } // namespace WebCore 1289 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/rendering/RenderTableSection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698