Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 898883003: Fixes play seek when user sets loop after ended. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Responding to feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 6f539a0bd30757c50c9e939d57f7547960ee2ceb..3bc0d8ae8e9ea86e31f6374ecd383bf794db4b08 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -411,10 +411,13 @@ private:
void updateVolume();
void updatePlayState();
bool potentiallyPlaying() const;
- bool endedPlayback() const;
bool stoppedDueToErrors() const;
bool couldPlayIfEnoughData() const;
+ enum class LoopFactor { Included, Ignored };
fs 2015/02/13 11:49:22 The "Factor" suffix made me go "huh?". I think usi
chcunningham 2015/02/13 23:01:43 Its like X-Factor :P But sure, LoopCondition it is
+ bool endedPlayback() const;
+ bool endedPlayback(LoopFactor) const;
+
void setShouldDelayLoadEvent(bool);
void invalidateCachedTime();
void refreshCachedTime() const;

Powered by Google App Engine
This is Rietveld 408576698