Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: LayoutTests/media/video-loop-expected.txt

Issue 898883003: Fixes play seek when user sets loop after ended. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Responding to feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 Test looping by: 1 Test looping by:
2 2
3 Play to end with 'loop' set to true. 3 Play to end with 'loop' set to true.
4 When 'seeked' event fires, verify that time has jumped back and movie is playing . 4 When 'seeked' event fires, verify that time has jumped back and movie is playing .
5 Set 'loop' to false and play again. 5 Set 'loop' to false and play again.
6 Verify that 'ended' event fires. 6 Verify that 'ended' event fires.
7 Set 'loop' to true now that video is ended. Call play again.
8 Verify 'seeked' event fires, verify that time has jumped back and movie is playi ng.
7 ++ Test setting/removing the attribute. 9 ++ Test setting/removing the attribute.
8 EXPECTED (video.getAttribute('loop') == 'null') OK 10 EXPECTED (video.getAttribute('loop') == 'null') OK
9 EXPECTED (video.loop == 'false') OK 11 EXPECTED (video.loop == 'false') OK
10 RUN(video.loop = true) 12 RUN(video.loop = true)
11 EXPECTED (video.loop == 'true') OK 13 EXPECTED (video.loop == 'true') OK
12 EXPECTED (video.getAttribute('loop') != 'null') OK 14 EXPECTED (video.getAttribute('loop') != 'null') OK
13 RUN(video.removeAttribute('loop')) 15 RUN(video.removeAttribute('loop'))
14 EXPECTED (video.loop == 'false') OK 16 EXPECTED (video.loop == 'false') OK
15 17
16 ++ Set 'loop' to true and begin playing. 18 ++ Set 'loop' to true and begin playing.
(...skipping 22 matching lines...) Expand all
39 EXPECTED (video.ended == 'false') OK 41 EXPECTED (video.ended == 'false') OK
40 RUN(video.pause()) 42 RUN(video.pause())
41 EXPECTED (mediaElement.currentTime >= '0') OK 43 EXPECTED (mediaElement.currentTime >= '0') OK
42 EXPECTED (mediaElement.currentTime < 'mediaElement.duration') OK 44 EXPECTED (mediaElement.currentTime < 'mediaElement.duration') OK
43 RUN(video.loop = false) 45 RUN(video.loop = false)
44 RUN(video.currentTime = video.duration - 0.4) 46 RUN(video.currentTime = video.duration - 0.4)
45 47
46 EVENT(pause) 48 EVENT(pause)
47 EVENT(seeked) 49 EVENT(seeked)
48 50
49 ++ third seek completed, beginning playback for the last time. 51 ++ third seek completed, unset 'loop' and let play to the end.
50 EXPECTED (video.paused == 'true') OK 52 EXPECTED (video.paused == 'true') OK
51 EXPECTED (video.ended == 'false') OK 53 EXPECTED (video.ended == 'false') OK
52 RUN(video.play()) 54 RUN(video.play())
53 55
54 EVENT(play) 56 EVENT(play)
55 EVENT(pause) 57 EVENT(pause)
56 EVENT(ended) 58 EVENT(ended)
57 59
58 ++ played to end and stopped. 60 ++ played to end and stopped.
59 EXPECTED (video.ended == 'true') OK 61 EXPECTED (video.ended == 'true') OK
60 EXPECTED (mediaElement.currentTime == 'mediaElement.duration') OK 62 EXPECTED (mediaElement.currentTime == 'mediaElement.duration') OK
61 63
64 ++ with ended == true, set 'loop' attribute. This will cause ended == false; loo ping video cannot be 'ended', only paused.
65 EXPECTED (video.loop == 'false') OK
66 EXPECTED (video.paused == 'true') OK
67 RUN(video.loop = true)
68 EXPECTED (video.loop == 'true') OK
69 EXPECTED (video.ended == 'false') OK
70 EXPECTED (video.paused == 'true') OK
71 RUN(video.play())
72
73 EVENT(play)
74 EVENT(seeked)
75
76 ++ fourth seek completed.
77 EXPECTED (mediaElement.currentTime < 'mediaElement.duration') OK
78 EXPECTED (video.loop == 'true') OK
79 EXPECTED (video.paused == 'false') OK
80 EXPECTED (video.ended == 'false') OK
81
82 ++ Pausing now that test is over to prevent additional unwanted looping.
83 RUN(video.pause())
84
62 END OF TEST 85 END OF TEST
63 86
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698