Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 898853002: Files.app: Move 'any file type' item to the end of filter list. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Move 'any file type' item to the end of filter list. In the dialog footer, we have a combobox to select a file type. Previously we have 'any file type' at the top of the list and it is selected by default. The CL moves it to the end of the list so that the first type is selected by default. BUG=454418 TEST=None Committed: https://crrev.com/13d5f845e78f390c60240de4ca6a04486749c511 Cr-Commit-Position: refs/heads/master@{#314507}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/dialog_footer.js View 1 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-04 04:23:04 UTC) #2
kinaba
lgtm. Thanks for handling this!
5 years, 10 months ago (2015-02-04 04:26:04 UTC) #3
hirono
On 2015/02/04 04:26:04, kinaba wrote: > lgtm. Thanks for handling this! Thanks!
5 years, 10 months ago (2015-02-04 04:29:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898853002/20001
5 years, 10 months ago (2015-02-04 04:29:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 04:55:53 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 04:57:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13d5f845e78f390c60240de4ca6a04486749c511
Cr-Commit-Position: refs/heads/master@{#314507}

Powered by Google App Engine
This is Rietveld 408576698