Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: media/base/android/media_source_player.cc

Issue 898843002: Use cached Key frames to avoid browser seek (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_decoder_job.cc ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_source_player.cc
diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc
index 53df8d3e6588cb72eae6696c4642d7ee86050a1c..bb42ac287d1f13fe4057f134452531ce01fcbf69 100644
--- a/media/base/android/media_source_player.cc
+++ b/media/base/android/media_source_player.cc
@@ -564,18 +564,25 @@ void MediaSourcePlayer::DecodeMoreAudio() {
DCHECK(!audio_decoder_job_->is_decoding());
DCHECK(!AudioFinished());
- if (audio_decoder_job_->Decode(
+ MediaDecoderJob::MediaDecoderJobStatus status = audio_decoder_job_->Decode(
start_time_ticks_,
start_presentation_timestamp_,
- base::Bind(&MediaSourcePlayer::MediaDecoderCallback, weak_this_, true))) {
- TRACE_EVENT_ASYNC_BEGIN0("media", "MediaSourcePlayer::DecodeMoreAudio",
- audio_decoder_job_.get());
- return;
- }
+ base::Bind(&MediaSourcePlayer::MediaDecoderCallback, weak_this_, true));
- is_waiting_for_audio_decoder_ = true;
- if (!IsEventPending(DECODER_CREATION_EVENT_PENDING))
- SetPendingEvent(DECODER_CREATION_EVENT_PENDING);
+ switch (status) {
+ case MediaDecoderJob::STATUS_SUCCESS:
+ TRACE_EVENT_ASYNC_BEGIN0("media", "MediaSourcePlayer::DecodeMoreAudio",
+ audio_decoder_job_.get());
+ break;
+ case MediaDecoderJob::STATUS_KEY_FRAME_REQUIRED:
+ NOTREACHED();
+ break;
+ case MediaDecoderJob::STATUS_FAILURE:
+ is_waiting_for_audio_decoder_ = true;
+ if (!IsEventPending(DECODER_CREATION_EVENT_PENDING))
+ SetPendingEvent(DECODER_CREATION_EVENT_PENDING);
+ break;
+ }
}
void MediaSourcePlayer::DecodeMoreVideo() {
@@ -583,25 +590,26 @@ void MediaSourcePlayer::DecodeMoreVideo() {
DCHECK(!video_decoder_job_->is_decoding());
DCHECK(!VideoFinished());
- if (video_decoder_job_->Decode(
+ MediaDecoderJob::MediaDecoderJobStatus status = video_decoder_job_->Decode(
start_time_ticks_,
start_presentation_timestamp_,
base::Bind(&MediaSourcePlayer::MediaDecoderCallback, weak_this_,
- false))) {
- TRACE_EVENT_ASYNC_BEGIN0("media", "MediaSourcePlayer::DecodeMoreVideo",
- video_decoder_job_.get());
- return;
+ false));
+
+ switch (status) {
+ case MediaDecoderJob::STATUS_SUCCESS:
+ TRACE_EVENT_ASYNC_BEGIN0("media", "MediaSourcePlayer::DecodeMoreVideo",
+ video_decoder_job_.get());
+ break;
+ case MediaDecoderJob::STATUS_KEY_FRAME_REQUIRED:
+ BrowserSeekToCurrentTime();
+ break;
+ case MediaDecoderJob::STATUS_FAILURE:
+ is_waiting_for_video_decoder_ = true;
+ if (!IsEventPending(DECODER_CREATION_EVENT_PENDING))
+ SetPendingEvent(DECODER_CREATION_EVENT_PENDING);
+ break;
}
-
- // If the decoder is waiting for iframe, trigger a browser seek.
- if (!video_decoder_job_->next_video_data_is_iframe()) {
- BrowserSeekToCurrentTime();
- return;
- }
-
- is_waiting_for_video_decoder_ = true;
- if (!IsEventPending(DECODER_CREATION_EVENT_PENDING))
- SetPendingEvent(DECODER_CREATION_EVENT_PENDING);
}
void MediaSourcePlayer::PlaybackCompleted(bool is_audio) {
« no previous file with comments | « media/base/android/media_decoder_job.cc ('k') | media/base/android/media_source_player_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698