Chromium Code Reviews Chromium Code Reviews
Issue
898803004:
Revert of Refactored pixel format resize operations in media/video/capture into a function called VideoCaptu… (Closed)
DescriptionRevert of Refactored pixel format resize operations in media/video/capture into a function called VideoCaptu… (patchset #13 id:240001 of https://codereview.chromium.org/897483002/)
Reason for revert:
This breaks the WebRTC real webcam tests on Windows. See for instance http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/13860. The error is
[2292:2232:0206/211958:997267:FATAL:video_capture_controller.cc(474)] Check failed: static_cast<size_t>(length) >= frame_format.ImageAllocationSize() (0 vs. 614400)
The Win bots are equipped with C920 webcams. I logged into the bot to make sure the webcam was working right - it is as far I can see.
Original issue's description:
> Refactored pixel format resize operations in media/video/capture into a function called VideoCaptureFormat::GetSizeForVideoPixelFormat().
>
> BUG=
>
> TEST=VideoCaptureDeviceTest.* in media_unittests pass.
>
> Committed: https://crrev.com/79288ba0b63021e8731e0401b8a4a9055d33fa10
> Cr-Commit-Position: refs/heads/master@{#315175}
TBR=mcasas@chromium.org,perkj@chromium.org,emircan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/b22a69d1b11489dacacbf0a710337a94714ac3d0
Cr-Commit-Position: refs/heads/master@{#315203}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 1 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
