Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 898753003: Infer HConstant::NotInNewSpace only if the supplied handle is null. (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Infer HConstant::NotInNewSpace only if the supplied handle is null. BUG=chromium:449291 LOG=n R=jkummerow@chromium.org Committed: https://crrev.com/4f786befb791878e672b22ebc414e7bac1956ab3 Cr-Commit-Position: refs/heads/master@{#26413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-449291.js View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-02-03 15:47:11 UTC) #1
Jakob Kummerow
LGTM
5 years, 10 months ago (2015-02-03 15:49:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898753003/1
5 years, 10 months ago (2015-02-03 16:10:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:47:30 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:48:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f786befb791878e672b22ebc414e7bac1956ab3
Cr-Commit-Position: refs/heads/master@{#26413}

Powered by Google App Engine
This is Rietveld 408576698