Issue 898723002: Use weak cell to embed property cell in StoreGlobal.

Issue 898723002: Use weak cell to embed property cell in StoreGlobal. (Closed)

Created:
5 years, 10 months ago by ulan

Modified:
5 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Use weak cell to embed property cell in StoreGlobal. BUG=v8:3629 LOG=N Committed: https://crrev.com/edb70555fff745825106061d083d964fd9cbc6ee Cr-Commit-Position: refs/heads/master@{#26396}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
M	src/code-stubs.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

ulan

PTAL. This is a follow-up for r26385. Remove the last raw pointer embedded in store ...

5 years, 10 months ago (2015-02-03 10:26:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898723002/60001

5 years, 10 months ago (2015-02-03 10:57:55 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 11:27:11 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/edb70555fff745825106061d083d964fd9cbc6ee
Cr-Commit-Position: refs/heads/master@{#26396}