Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 898713004: Revert of Roll Clang 223108:228129 (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, kjellander_chromium, Alexander Potapenko, zerny-chromium
Base URL:
precise:/work/chromium/src@clang_roll_226907
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Clang 223108:228129 (patchset #5 id:80001 of https://codereview.chromium.org/881763003/) Reason for revert: compiler crash in http://build.chromium.org/p/chromium/builders/Mac/builds/33226 Assertion failed: (Offset <= PieceOffset && "overlapping or duplicate pieces"), function emitLocPieces, file /work/chromium/src/third_party/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp, line 1676. 0. Program arguments: /Volumes/data/b/build/slave/Mac/build/src/third_party/llvm-build/Release+Asserts/bin/clang -cc1 -triple x86_64-apple-macosx10.6.0 /* snip */ -x c ../../third_party/mesa/src/src/mesa/program/prog_opt_constant_fold.c 1. <eof> parser at end of file 2. Code generation clang:error: unable to execute command: Illegal instruction: 4 clang:error: clang frontend command failed due to signal (use -v to see invocation) clang version 3.7.0 (trunk 228129) Target: x86_64-apple-darwin13.4.0 Original issue's description: > Roll Clang 223108:228129 > > Also introduce a build number in the package name, stop versioning > the Blink GC plugin, and remove repackage.sh. > > BUG=444089 > > Committed: https://crrev.com/d30327adf468b78f79819a69bca12b64b7cb70ae > Cr-Commit-Position: refs/heads/master@{#314946} TBR=thakis@chromium.org,jln@chromium.org,jbauman@chromium.org,hans@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444089 Committed: https://crrev.com/5b459de080948b999f50194e468c38c8d71e8384 Cr-Commit-Position: refs/heads/master@{#314950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -32 lines) Patch
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/plugins/tests/weak_ptr_factory.flags View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 2 chunks +4 lines, -1 line 0 comments Download
M tools/clang/scripts/package.sh View 4 chunks +7 lines, -5 lines 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 chunk +2 lines, -1 line 0 comments Download
A tools/clang/scripts/repackage.sh View 1 chunk +67 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 7 chunks +357 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
Created Revert of Roll Clang 223108:228129
5 years, 10 months ago (2015-02-06 02:41:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898713004/1
5 years, 10 months ago (2015-02-06 02:42:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 02:44:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b459de080948b999f50194e468c38c8d71e8384 Cr-Commit-Position: refs/heads/master@{#314950}
5 years, 10 months ago (2015-02-06 02:45:37 UTC) #4
tapted
On 2015/02/06 02:45:37, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-02-06 03:35:08 UTC) #5
Nico
5 years, 10 months ago (2015-02-06 04:19:39 UTC) #6
Message was sent while issue was closed.
That didn't last long. Thanks for the revert! Sorry that the try bots
missed this.
On Feb 5, 2015 7:35 PM, <tapted@chromium.org> wrote:

> On 2015/02/06 02:45:37, I haz the power (commit-bot) wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/5b459de080948b999f50194e468c38c8d71e8384
>> Cr-Commit-Position: refs/heads/master@{#314950}
>>
>
> Looks like it might be a 64-bit or official-builder thing.
> https://build.chromium.org/p/chromium.chrome/builders/
> Google%20Chrome%20Linux%20x64
> also has the crash.
>
> Things are going green after the revert.
>
> https://codereview.chromium.org/898713004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698