src/IceOperand.h - Issue 898693002: Subzero: Fix some -Winconsistent-missing-override that clang 3.6 warns about.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceOperand.h

Issue 898693002: Subzero: Fix some -Winconsistent-missing-override that clang 3.6 warns about. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceOperand.h

diff --git a/src/IceOperand.h b/src/IceOperand.h

index 5019e292c4d50f6efa951cb5266f73b5f9e0af94..cfe203844fa5e6282fe8bdd4f80aa179baff233c 100644

--- a/src/IceOperand.h

+++ b/src/IceOperand.h

@@ -107,7 +107,6 @@ public:

using Operand::dump;

Jim Stichnoth 2015/02/03 05:31:18 Can you also remove this line?

jvoung (off chromium) 2015/02/03 16:17:56 Done.

void emit(const Cfg *Func) const override { emit(Func->getContext()); }

virtual void emit(GlobalContext *Ctx) const = 0;

- void dump(const Cfg *Func, Ostream &Str) const = 0;

static bool classof(const Operand *Operand) {

OperandKind Kind = Operand->getKind();

« no previous file with comments | « src/IceInst.h ('k') | src/IceTargetLoweringX8632.h » ('j') | no next file with comments »