Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner.py

Issue 898673005: [telemetry] Add a V8GCTimes measurement and benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/action_runner.py
diff --git a/tools/telemetry/telemetry/page/actions/action_runner.py b/tools/telemetry/telemetry/page/actions/action_runner.py
index 090370d40c4e25f2ed5c118dda2e1ed116dc086c..4f38174ab0c7e197391f72219110ceb1824a2206 100644
--- a/tools/telemetry/telemetry/page/actions/action_runner.py
+++ b/tools/telemetry/telemetry/page/actions/action_runner.py
@@ -33,8 +33,8 @@ class ActionRunner(object):
action.WillRunAction(self._tab)
action.RunAction(self._tab)
- def BeginInteraction(self, label, is_fast=False, is_smooth=False,
- is_responsive=False, repeatable=False):
+ def BeginInteraction(self, label, is_smooth=False, is_responsive=False,
+ repeatable=False):
"""Marks the beginning of an interaction record.
An interaction record is a labeled time period containing
@@ -46,8 +46,6 @@ class ActionRunner(object):
Args:
label: A label for this particular interaction. This can be any
user-defined string, but must not contain '/'.
- is_fast: Whether to measure how fast the browser completes necessary work
- for this interaction record. See fast_metric.py for details.
is_smooth: Whether to check for smoothness metrics for this interaction.
is_responsive: Whether to check for responsiveness metrics for
this interaction.
@@ -56,8 +54,6 @@ class ActionRunner(object):
have the same flags.
"""
flags = []
- if is_fast:
- flags.append(timeline_interaction_record.IS_FAST)
if is_smooth:
flags.append(timeline_interaction_record.IS_SMOOTH)
if is_responsive:
@@ -69,8 +65,8 @@ class ActionRunner(object):
interaction.Begin()
return interaction
- def BeginGestureInteraction(self, label, is_fast=False, is_smooth=False,
- is_responsive=False, repeatable=False):
+ def BeginGestureInteraction(self, label, is_smooth=False, is_responsive=False,
+ repeatable=False):
"""Marks the beginning of a gesture-based interaction record.
This is similar to normal interaction record, but it will
@@ -84,8 +80,6 @@ class ActionRunner(object):
Args:
label: A label for this particular interaction. This can be any
user-defined string, but must not contain '/'.
- is_fast: Whether to measure how fast the browser completes necessary work
- for this interaction record. See fast_metric.py for details.
is_smooth: Whether to check for smoothness metrics for this interaction.
is_responsive: Whether to check for responsiveness metrics for
this interaction.
@@ -93,8 +87,8 @@ class ActionRunner(object):
as this interaction. All interactions with the same logical name must
have the same flags.
"""
- return self.BeginInteraction('Gesture_' + label, is_fast, is_smooth,
- is_responsive, repeatable)
+ return self.BeginInteraction('Gesture_' + label, is_smooth, is_responsive,
+ repeatable)
def NavigateToPage(self, page, timeout_in_seconds=60):
"""Navigates to the given page.

Powered by Google App Engine
This is Rietveld 408576698