Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 898673003: Refactor Material Design PDF Viewer toolbar into a single element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase from master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
index f2a5fb3595995d98d06d8165cc7989e12303f8c1..97713d53eb84e6d5e8c634ef1c63d95f6bd107f7 100644
--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js
@@ -5,18 +5,34 @@
var DIGIT_LENGTH = 0.6;
Polymer('viewer-page-selector', {
- // The current entry in the input field (1-based).
+ /**
+ * @type {string}
+ * The current entry in the input field (1-based).
+ */
pageNo: '1',
- // The index of the current page being viewed (0-based).
+
+ /**
+ * @type {number}
+ * The index of the current page being viewed (0-based).
+ */
index: 0,
+
+ /**
+ * @type {number}
+ * The number of pages the document contains.
+ */
docLength: 1,
- // The submitted input from the user (1-based).
+
+ /**
+ * @type {string}
+ * The submitted input from the user (1-based).
+ */
chosenPageNo: '1',
chosenPageNoChanged: function() {
var page = parseInt(this.chosenPageNo);
if (!isNaN(page)) {
- this.fire('changePage', {page: page - 1});
+ this.fire('change-page', {page: page - 1});
} else {
// Repopulate the input.
this.indexChanged();

Powered by Google App Engine
This is Rietveld 408576698