chrome/browser/resources/pdf/index-material.html - Issue 898673003: Refactor Material Design PDF Viewer toolbar into a single element

Side by Side Diff: chrome/browser/resources/pdf/index-material.html

Issue 898673003: Refactor Material Design PDF Viewer toolbar into a single element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve variable naming and documentation Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js ('K') | « chrome/browser/resources/pdf/index-material.css ('k') | chrome/browser/resources/pdf/pdf.js » ('j') | chrome/browser/resources/pdf/pdf.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="import" href="elements/viewer-bookmarks-pane/viewer-bookmarks-pane. html">	5 <link rel="import" href="elements/viewer-bookmarks-pane/viewer-bookmarks-pane. html">

6 <link rel="import" href="elements/viewer-button/viewer-button.html">	6 <link rel="import" href="elements/viewer-button/viewer-button.html">

7 <link rel="import" href="elements/viewer-error-screen/viewer-error-screen.html ">	7 <link rel="import" href="elements/viewer-error-screen/viewer-error-screen.html ">

8 <link rel="import" href="elements/viewer-page-selector/viewer-page-selector.ht ml">	8 <link rel="import" href="elements/viewer-page-selector/viewer-page-selector.ht ml">

9 <link rel="import" href="elements/viewer-password-screen/viewer-password-scree n.html">	9 <link rel="import" href="elements/viewer-password-screen/viewer-password-scree n.html">

	10 <link rel="import" href="elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html">

10 <link rel="import" href="elements/viewer-toolbar/viewer-toolbar.html">	11 <link rel="import" href="elements/viewer-toolbar/viewer-toolbar.html">

11	12

12 <link rel="import" href="chrome://resources/polymer/core-toolbar/core-toolbar. html">

13 <link rel="import" href="chrome://resources/polymer/paper-icon-button/paper-ic on-button.html">

14 <link rel="import" href="chrome://resources/polymer/paper-progress/paper-progr ess.html">

15 <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow. html">

16

17 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	13 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

18 <link rel="stylesheet" type="text/css" href="index-material.css">	14 <link rel="stylesheet" type="text/css" href="index-material.css">

19 </head>	15 </head>

20 <body>	16 <body>

21 <paper-shadow id="toolbar-shadow" z="1">

22 <paper-progress value="0" id="progress-bar"></paper-progress>

23 <core-toolbar id="pdf-toolbar" class="core-narrow">

24 <span id="title" flex></span>

25	17

26 <viewer-page-selector id="page-indicator" flex></viewer-page-selector>	18 <viewer-pdf-toolbar id="material-toolbar"></viewer-pdf-toolbar>
	raymes 2015/02/04 00:54:25 nit: can we just call this "viewer-toolbar"? nit: can we just call this "viewer-toolbar"? Alexandre Carlton 2015/02/04 04:28:46 Until the new Polymer zoom element is finished we Show quoted text On 2015/02/04 00:54:25, raymes wrote: > nit: can we just call this "viewer-toolbar"? Until the new Polymer zoom element is finished we will still have viewer-toolbar at the bottom-right of the screen (necessary for the non-material viewer).
27

28 <paper-icon-button icon="bookmark-outline" id="bookmarks-button"></paper-ico n-button>

29 <paper-icon-button icon="file-download" id="save-button"></paper-icon-button >

30 <paper-icon-button icon="print" id="print-button"></paper-icon-button>

31 </core-toolbar>

32 </paper-shadow>

33	19

34 <viewer-bookmarks-pane id="bookmarks-pane" heading="Bookmarks"></viewer-bookmark s-pane>	20 <viewer-bookmarks-pane id="bookmarks-pane" heading="Bookmarks"></viewer-bookmark s-pane>

35	21

36 <div id="sizer"></div>	22 <div id="sizer"></div>

37 <viewer-password-screen id="password-screen"></viewer-password-screen>	23 <viewer-password-screen id="password-screen"></viewer-password-screen>

38	24

39 <viewer-toolbar id="toolbar">	25 <viewer-toolbar id="toolbar">

40 <viewer-button id="fit-to-page-button"	26 <viewer-button id="fit-to-page-button"

41 assetpath="elements/viewer-button/"	27 assetpath="elements/viewer-button/"

42 img="button_fit_page.png" latchable>	28 img="button_fit_page.png" latchable>

(...skipping 16 matching lines...) Expand all Loading...
59	45

60 </body>	46 </body>

61 <script src="viewport.js"></script>	47 <script src="viewport.js"></script>

62 <script src="open_pdf_params_parser.js"></script>	48 <script src="open_pdf_params_parser.js"></script>

63 <script src="navigator.js"></script>	49 <script src="navigator.js"></script>

64 <script src="pdf_scripting_api.js"></script>	50 <script src="pdf_scripting_api.js"></script>

65 <script src="chrome://resources/js/util.js"></script>	51 <script src="chrome://resources/js/util.js"></script>

66 <script src="pdf.js"></script>	52 <script src="pdf.js"></script>

67 <script src="main.js"></script>	53 <script src="main.js"></script>

68 </html>	54 </html>

OLD	NEW