Refactor Material Design PDF Viewer toolbar into a single element

chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Polymer('viewer-pdf-toolbar', {
+
+  filename: '',

[benwells, 2015/02/03 06:31:33]

I think you can probably remove the blank line above.

[Sam McNally, 2015/02/03 07:22:45]

How about "title"?

Please add comments for these attributes.

[Alexandre Carlton, 2015/02/03 22:50:42]

I'm a bit resistant to change it to 'title' since the title of a PDF document
can greatly differ to its filename. raymes@, what do you think?

[Alexandre Carlton, 2015/02/03 22:50:42]

Done.

[Sam McNally, 2015/02/08 23:30:47]

Let's call this title. It doesn't necessarily mean the PDF's title, but rather
whatever the user of this element decides the title is, which happens to be the
filename right now.

[Alexandre Carlton, 2015/02/09 03:44:05]

The 'title' attribute is special when dealing with HTML elements, so I've named
it docTitle.
Reference:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title

+  index: '0',

[Sam McNally, 2015/02/03 07:22:45]

In a toolbar element it isn't obvious what this is referring to. How about
pageIndex?

[Alexandre Carlton, 2015/02/03 22:50:42]

Done.

+  progress: 0,

[Sam McNally, 2015/02/03 07:22:45]

Similarly, loadProgress?

[Alexandre Carlton, 2015/02/03 22:50:42]

Done.

+  docLength: 1,
+
+  progressChanged: function() {
+    if (this.progress >= 100)
+      this.$.pageselector.style.visibility = 'visible';
+  },
+
+  toggleBookmarks: function() {
+    this.fire('toggle-bookmarks');
+  },
+  save: function() {

[benwells, 2015/02/03 06:31:33]

For consistency, please have a blank line between all the functions (or
alternatively, none, but all is probably more readable).

[Alexandre Carlton, 2015/02/03 22:50:42]

Done.

+    this.fire('save');
+  },
+  print: function() {
+    this.fire('print');
+  },
+});