Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 898663005: Add a flag to track detached contexts. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a flag to track detached contexts. When embedder detaches the global objects, its context must be garbage collected eventually. BUG= Committed: https://crrev.com/b7d27ea58307e9201c1196cf2cf523205cd8ab60 Cr-Commit-Position: refs/heads/master@{#26450}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ulan
PTAL https://codereview.chromium.org/898663005/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/898663005/diff/1/src/isolate.cc#newcode2607 src/isolate.cc:2607: static_cast<void*>(cell->value()), mark_sweeps); Would be nice to print the ...
5 years, 10 months ago (2015-02-04 15:39:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 17:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898663005/60001
5 years, 10 months ago (2015-02-05 09:12:38 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-05 09:35:55 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 09:36:08 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b7d27ea58307e9201c1196cf2cf523205cd8ab60
Cr-Commit-Position: refs/heads/master@{#26450}

Powered by Google App Engine
This is Rietveld 408576698