Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: build/common.gypi

Issue 89863002: Move the logic for getting icu data out of icu_util (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: set the flag to 0 by default Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 97e8596bd021e114af6db6b25e4439b7ddb5c89b..192037d5954a54787f160165355bd74dedce986c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1217,6 +1217,10 @@
# Relative path to icu.gyp from this file.
'icu_gyp_path': '../third_party/icu/icu.gyp',
+ # Whether or not to use "icu*.dat" file for ICU data.
+ # Do not use it by default.
+ 'icu_use_data_file_flag%': 0,
+
'conditions': [
# The version of GCC in use, set later in platforms that use GCC and have
# not explicitly chosen to build with clang. Currently, this means all
@@ -2157,6 +2161,17 @@
['use_udev==1', {
'defines': ['USE_UDEV'],
}],
+ ['icu_use_data_file_flag==1', {
+ 'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE'],
+ }, { # else icu_use_data_file_flag !=1
+ 'conditions': [
+ ['OS=="win"', {
+ 'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED'],
+ }, {
+ 'defines': ['ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC'],
+ }],
+ ],
+ }],
['fastbuild!=0', {
'xcode_settings': {
'GCC_GENERATE_DEBUGGING_SYMBOLS': 'NO',
« base/i18n/icu_util.cc ('K') | « base/i18n/icu_util.cc ('k') | url/url.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698