Issue 898623002: Make mojo::system::Core not own the PlatformSupport.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898623002: Make mojo::system::Core not own the PlatformSupport. (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make mojo::system::Core not own the PlatformSupport. This is so that we can reasonably have other un-/barely-/loosely-coupled things have a pointer to the PlatformSupport. For now, keep the embedder API the same (the embedder still takes ownership of the PlatformSupport on Init()). It's unclear if this is ideal, but it's not a big deal. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d14187fb1902c2f4b091d49f600ce937f9371a2d

Patch Set 1 #

Patch Set 2 : update comment #

Patch Set 3 : foo #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -14 lines)			Patch
M	mojo/edk/embedder/embedder.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	mojo/edk/embedder/embedder_internal.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	mojo/edk/embedder/test_embedder.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	mojo/edk/system/channel.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	mojo/edk/system/core.h	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	mojo/edk/system/core.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/edk/system/core_test_base.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/edk/system/core_test_base.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 10 months ago (2015-02-03 00:52:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
d14187fb1902c2f4b091d49f600ce937f9371a2d (presubmit successful).

Expand Messages | Collapse Messages