Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/renderer/prerender/prerender_dispatcher.cc

Issue 898613004: Sanitize referrers before we create them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/prerender/prerender_dispatcher.h" 5 #include "chrome/renderer/prerender/prerender_dispatcher.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/common/prerender_messages.h" 8 #include "chrome/common/prerender_messages.h"
9 #include "chrome/common/prerender_types.h" 9 #include "chrome/common/prerender_types.h"
10 #include "chrome/renderer/prerender/prerender_extra_data.h" 10 #include "chrome/renderer/prerender/prerender_extra_data.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 } 133 }
134 134
135 prerenders_[extra_data.prerender_id()] = prerender; 135 prerenders_[extra_data.prerender_id()] = prerender;
136 136
137 PrerenderAttributes attributes; 137 PrerenderAttributes attributes;
138 attributes.url = GURL(prerender.url()); 138 attributes.url = GURL(prerender.url());
139 attributes.rel_types = prerender.relTypes(); 139 attributes.rel_types = prerender.relTypes();
140 140
141 content::RenderThread::Get()->Send(new PrerenderHostMsg_AddLinkRelPrerender( 141 content::RenderThread::Get()->Send(new PrerenderHostMsg_AddLinkRelPrerender(
142 extra_data.prerender_id(), attributes, 142 extra_data.prerender_id(), attributes,
143 content::Referrer(GURL(prerender.referrer()), 143 content::Referrer::SanitizeForRequest(
144 prerender.referrerPolicy()), 144 GURL(prerender.url()), content::Referrer(GURL(prerender.referrer()),
145 prerender.referrerPolicy())),
145 extra_data.size(), extra_data.render_view_route_id())); 146 extra_data.size(), extra_data.render_view_route_id()));
146 } 147 }
147 148
148 void PrerenderDispatcher::cancel(const WebPrerender& prerender) { 149 void PrerenderDispatcher::cancel(const WebPrerender& prerender) {
149 const PrerenderExtraData& extra_data = 150 const PrerenderExtraData& extra_data =
150 PrerenderExtraData::FromPrerender(prerender); 151 PrerenderExtraData::FromPrerender(prerender);
151 content::RenderThread::Get()->Send( 152 content::RenderThread::Get()->Send(
152 new PrerenderHostMsg_CancelLinkRelPrerender(extra_data.prerender_id())); 153 new PrerenderHostMsg_CancelLinkRelPrerender(extra_data.prerender_id()));
153 // The browser will not send an OnPrerenderStop (the prerender may have even 154 // The browser will not send an OnPrerenderStop (the prerender may have even
154 // been canceled before it was started), so release it to avoid a 155 // been canceled before it was started), so release it to avoid a
155 // leak. Moreover, if it did, the PrerenderClient in Blink will have been 156 // leak. Moreover, if it did, the PrerenderClient in Blink will have been
156 // detached already. 157 // detached already.
157 prerenders_.erase(extra_data.prerender_id()); 158 prerenders_.erase(extra_data.prerender_id());
158 } 159 }
159 160
160 void PrerenderDispatcher::abandon(const WebPrerender& prerender) { 161 void PrerenderDispatcher::abandon(const WebPrerender& prerender) {
161 const PrerenderExtraData& extra_data = 162 const PrerenderExtraData& extra_data =
162 PrerenderExtraData::FromPrerender(prerender); 163 PrerenderExtraData::FromPrerender(prerender);
163 content::RenderThread::Get()->Send( 164 content::RenderThread::Get()->Send(
164 new PrerenderHostMsg_AbandonLinkRelPrerender(extra_data.prerender_id())); 165 new PrerenderHostMsg_AbandonLinkRelPrerender(extra_data.prerender_id()));
165 // The browser will not send an OnPrerenderStop (the prerender may have even 166 // The browser will not send an OnPrerenderStop (the prerender may have even
166 // been canceled before it was started), so release it to avoid a 167 // been canceled before it was started), so release it to avoid a
167 // leak. Moreover, if it did, the PrerenderClient in Blink will have been 168 // leak. Moreover, if it did, the PrerenderClient in Blink will have been
168 // detached already. 169 // detached already.
169 prerenders_.erase(extra_data.prerender_id()); 170 prerenders_.erase(extra_data.prerender_id());
170 } 171 }
171 172
172 } // namespace prerender 173 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698