Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 898603002: [Extensions Toolbar] Observe original profile for extension host notifications (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Observe original profile for extension host notifications Extension host closed notifications are sent from the original profile (never the incognito profile). Use the original profile when listening for these notifications. BUG=454320 Committed: https://crrev.com/8925821521cea9d27b31ada6b184f8d84d534ad1 Cr-Commit-Position: refs/heads/master@{#314360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/extensions/extension_action_view_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
5 years, 10 months ago (2015-02-03 16:17:35 UTC) #2
Finnur
LGTM
5 years, 10 months ago (2015-02-03 16:27:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898603002/1
5 years, 10 months ago (2015-02-03 17:43:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:46:47 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:47:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8925821521cea9d27b31ada6b184f8d84d534ad1
Cr-Commit-Position: refs/heads/master@{#314360}

Powered by Google App Engine
This is Rietveld 408576698