Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 898593004: Revert of Revert of Standardize "gpu_times" metric names and add GPU rasterization versions. (Closed)

Created:
5 years, 10 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 10 months ago
Reviewers:
epenner, vmiura, David Yen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Standardize "gpu_times" metric names and add GPU rasterization versions. (patchset #1 id:1 of https://codereview.chromium.org/896593002/) Reason for revert: Reverting the revert; looks like this wasn't the culprit. Original issue's description: > Revert of Standardize "gpu_times" metric names and add GPU rasterization versions. (patchset #2 id:20001 of https://codereview.chromium.org/875473003/) > > Reason for revert: > Speculative revert for crbug.com/453131 > > Original issue's description: > > Standardize "gpu_times" metric names and add GPU rasterization versions. > > > > The GPU Times metric event names have been standardized to match the > > names for other metrics. GPU Rasterization versions have also been > > added for both GPU times tests. Here is the list of test names: > > gpu_times.gpu_rasterization.key_mobile_sites_smooth > > gpu_times.gpu_rasterization.top_25_smooth > > gpu_times.key_mobile_sites_smooth > > gpu_times.top_25_smooth > > > > R=vmiura@chromium.org > > BUG=none > > test=trybots > > > > Committed: https://crrev.com/9fbe73b4158beb6beb278af819e075cc3d744210 > > Cr-Commit-Position: refs/heads/master@{#313825} > > TBR=vmiura@chromium.org,epenner@chromium.org,dyen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://crrev.com/92a5662c9732fb41f2afc2026ed0e6b4e9c1fcd3 > Cr-Commit-Position: refs/heads/master@{#314192} TBR=vmiura@chromium.org,epenner@chromium.org,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/d8ea3d2d37fa3469325d960e1f23d3912ed31303 Cr-Commit-Position: refs/heads/master@{#314224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/perf/benchmarks/gpu_times.py View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Revert of Standardize "gpu_times" metric names and add GPU rasterization versions.
5 years, 10 months ago (2015-02-03 00:29:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898593004/1
5 years, 10 months ago (2015-02-03 00:31:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 00:33:26 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 00:35:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8ea3d2d37fa3469325d960e1f23d3912ed31303
Cr-Commit-Position: refs/heads/master@{#314224}

Powered by Google App Engine
This is Rietveld 408576698