Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: Source/core/storage/StorageArea.cpp

Issue 898593002: DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed assertion Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/storage/StorageArea.cpp
diff --git a/Source/core/storage/StorageArea.cpp b/Source/core/storage/StorageArea.cpp
index fbf2a17a0b4d8b423a1be1edf241ce8d0cc48963..a2f2c3df163a516f25d89132ae1ed6969ce3a49b 100644
--- a/Source/core/storage/StorageArea.cpp
+++ b/Source/core/storage/StorageArea.cpp
@@ -174,8 +174,8 @@ void StorageArea::dispatchLocalStorageEvent(const String& key, const String& old
Storage* storage = DOMWindowStorage::from(*localWindow).optionalLocalStorage();
if (storage && localFrame->document()->securityOrigin()->canAccess(securityOrigin) && !isEventSource(storage, sourceAreaInstance))
localFrame->localDOMWindow()->enqueueWindowEvent(StorageEvent::create(EventTypeNames::storage, key, oldValue, newValue, pageURL, storage));
+ InspectorInstrumentation::didDispatchDOMStorageEvent(localFrame, key, oldValue, newValue, LocalStorage, securityOrigin);
}
- InspectorInstrumentation::didDispatchDOMStorageEvent(page, key, oldValue, newValue, LocalStorage, securityOrigin);
}
}
@@ -207,8 +207,8 @@ void StorageArea::dispatchSessionStorageEvent(const String& key, const String& o
Storage* storage = DOMWindowStorage::from(*localWindow).optionalSessionStorage();
if (storage && localFrame->document()->securityOrigin()->canAccess(securityOrigin) && !isEventSource(storage, sourceAreaInstance))
localFrame->localDOMWindow()->enqueueWindowEvent(StorageEvent::create(EventTypeNames::storage, key, oldValue, newValue, pageURL, storage));
+ InspectorInstrumentation::didDispatchDOMStorageEvent(localFrame, key, oldValue, newValue, SessionStorage, securityOrigin);
}
- InspectorInstrumentation::didDispatchDOMStorageEvent(page, key, oldValue, newValue, SessionStorage, securityOrigin);
}
bool StorageArea::isEventSource(Storage* storage, WebStorageArea* sourceAreaInstance)
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698