Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: Source/core/inspector/PageConsoleAgent.h

Issue 898593002: DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed assertion Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorTracingAgent.cpp ('k') | Source/core/inspector/PageConsoleAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageConsoleAgent.h
diff --git a/Source/core/inspector/PageConsoleAgent.h b/Source/core/inspector/PageConsoleAgent.h
index 11c9f107c4f1b8da364106499393dfdf57cd457c..972aba75e1e17021c8c1ee7cc1b9e5dfaa5dfdc1 100644
--- a/Source/core/inspector/PageConsoleAgent.h
+++ b/Source/core/inspector/PageConsoleAgent.h
@@ -39,16 +39,16 @@ namespace blink {
class ConsoleMessage;
class ConsoleMessageStorage;
class InspectorDOMAgent;
-class Page;
+class InspectorPageAgent;
class WorkerInspectorProxy;
class WorkerGlobalScopeProxy;
class PageConsoleAgent final : public InspectorConsoleAgent {
WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
public:
- static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(InjectedScriptManager* injectedScriptManager, InspectorDOMAgent* domAgent, Page* page)
+ static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(InjectedScriptManager* injectedScriptManager, InspectorDOMAgent* domAgent, InspectorPageAgent* pageAgent)
{
- return adoptPtrWillBeNoop(new PageConsoleAgent(injectedScriptManager, domAgent, page));
+ return adoptPtrWillBeNoop(new PageConsoleAgent(injectedScriptManager, domAgent, pageAgent));
}
virtual ~PageConsoleAgent();
virtual void trace(Visitor*) override;
@@ -69,12 +69,12 @@ protected:
virtual void disableStackCapturingIfNeeded() override;
private:
- PageConsoleAgent(InjectedScriptManager*, InspectorDOMAgent*, Page*);
+ PageConsoleAgent(InjectedScriptManager*, InspectorDOMAgent*, InspectorPageAgent*);
virtual void clearMessages(ErrorString*) override;
virtual void addInspectedNode(ErrorString*, int nodeId) override;
RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;
- RawPtrWillBeMember<Page> m_page;
+ RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;
HashSet<WorkerGlobalScopeProxy*> m_workersWithEnabledConsole;
static int s_enabledAgentCount;
« no previous file with comments | « Source/core/inspector/InspectorTracingAgent.cpp ('k') | Source/core/inspector/PageConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698