Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: Source/bindings/core/v8/PageScriptDebugServer.h

Issue 898593002: DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed assertion Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/PageScriptDebugServer.h
diff --git a/Source/bindings/core/v8/PageScriptDebugServer.h b/Source/bindings/core/v8/PageScriptDebugServer.h
index bbd8b6b2d88f1d2da5c6d82dd7f38b617c5828d6..3c702e06642e64a61c2e15f09d7d15c950d3191a 100644
--- a/Source/bindings/core/v8/PageScriptDebugServer.h
+++ b/Source/bindings/core/v8/PageScriptDebugServer.h
@@ -50,15 +50,15 @@ public:
static void setMainThreadIsolate(v8::Isolate*);
- void addListener(ScriptDebugListener*, Page*);
- void removeListener(ScriptDebugListener*, Page*);
+ void addListener(ScriptDebugListener*, LocalFrame*);
+ void removeListener(ScriptDebugListener*, LocalFrame*);
static void interruptAndRun(PassOwnPtr<Task>);
class ClientMessageLoop {
public:
virtual ~ClientMessageLoop() { }
- virtual void run(Page*) = 0;
+ virtual void run(LocalFrame*) = 0;
virtual void quitNow() = 0;
};
void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);
@@ -82,10 +82,10 @@ private:
void runMessageLoopOnPause(v8::Handle<v8::Context>) override;
void quitMessageLoopOnPause() override;
- using ListenersMap = WillBeHeapHashMap<RawPtrWillBeMember<Page>, ScriptDebugListener*>;
+ using ListenersMap = WillBeHeapHashMap<RawPtrWillBeMember<LocalFrame>, ScriptDebugListener*>;
ListenersMap m_listenersMap;
OwnPtr<ClientMessageLoop> m_clientMessageLoop;
- RawPtrWillBeMember<Page> m_pausedPage;
+ RawPtrWillBeMember<LocalFrame> m_pausedFrame;
HashMap<String, String> m_compiledScriptURLs;
ScriptSourceCode m_preprocessorSourceCode;
« no previous file with comments | « no previous file | Source/bindings/core/v8/PageScriptDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698