DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones.

Source/core/inspector/InspectorDOMStorageAgent.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 168 matching lines @@
     *errorString = toErrorString(exceptionState);
 }
 
 PassRefPtr<TypeBuilder::DOMStorage::StorageId> InspectorDOMStorageAgent::storageId(SecurityOrigin* securityOrigin, bool isLocalStorage)
 {
     return TypeBuilder::DOMStorage::StorageId::create()
         .setSecurityOrigin(securityOrigin->toRawString())
         .setIsLocalStorage(isLocalStorage).release();
 }
 
-void InspectorDOMStorageAgent::didDispatchDOMStorageEvent(const String& key, const String& oldValue, const String& newValue, StorageType storageType, SecurityOrigin* securityOrigin)
+void InspectorDOMStorageAgent::didDispatchDOMStorageEvent(LocalFrame* frame, const String& key, const String& oldValue, const String& newValue, StorageType storageType, SecurityOrigin* securityOrigin)
 {
-    if (!m_frontend || !isEnabled())
+    if (!m_frontend || !isEnabled() || !frame->isMainFrame())

[yurys, 2015/02/03 06:44:00]

How are we supposed to track dom storage events in child frame's processes?

[pfeldman, 2015/02/03 07:09:16]

I'll replace it with the check for being pageAgent's mainFrame. Other processes
will be inspected separately.

         return;
 
     RefPtr<TypeBuilder::DOMStorage::StorageId> id = storageId(securityOrigin, storageType == LocalStorage);
 
     if (key.isNull())
         m_frontend->domStorageItemsCleared(id);
     else if (newValue.isNull())
         m_frontend->domStorageItemRemoved(id, key);
     else if (oldValue.isNull())
         m_frontend->domStorageItemAdded(id, key, newValue);
@@ skipping 17 matching lines @@
     LocalFrame* frame = m_pageAgent->findFrameWithSecurityOrigin(securityOrigin);
     if (!frame) {
         if (errorString)
             *errorString = "LocalFrame not found for the given security origin";
         return nullptr;
     }
     targetFrame = frame;
 
     if (isLocalStorage)
         return StorageNamespace::localStorageArea(frame->document()->securityOrigin());
-    return StorageNamespaceController::from(m_pageAgent->page())->sessionStorage()->storageArea(frame->document()->securityOrigin());
+    return StorageNamespaceController::from(frame->page())->sessionStorage()->storageArea(frame->document()->securityOrigin());

[yurys, 2015/02/03 06:44:00]

Frame::page() is being deprecated, you shouldn't add new usages, can we simply
revert this?

[pfeldman, 2015/02/03 07:09:16]

This part is particularly stupid. I'll follow up. There should be a direct way
of getting storage area.

 }
 
 } // namespace blink