add textual overview

add textual overview

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bf015c34e4c36467dfef385893f375b68718450e

[reed1, 2015-02-02 20:56:33]

reed@google.com changed reviewers:
+ djsollen@google.com

[reed1, 2015-02-02 20:56:36]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-02-02 20:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898573002/1

[commit-bot: I haz the power, 2015-02-02 20:56:46]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-03 02:56 UTC

[reed1, 2015-02-03 00:10:09]

ptal

[djsollen, 2015-02-03 00:52:12]

can we have both a pictures GM and a names GM?  I don't think it should be a
compile time decision which one you get.  How about toggling between the 2 of
them?

[commit-bot: I haz the power, 2015-02-03 02:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 02:56:48]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[reed1, 2015-02-03 15:53:53]

On 2015/02/03 00:52:12, djsollen wrote:
> can we have both a pictures GM and a names GM?  I don't think it should be a
> compile time decision which one you get.  How about toggling between the 2 of
> them?

I find the pictures unbearably slow (and even fewer fit. How about I just delete
that code?

[djsollen, 2015-02-03 15:58:18]

I'm good with that

[reed1, 2015-02-03 16:39:42]

The CQ bit was checked by reed@google.com

[reed1, 2015-02-03 16:39:58]

ptal

[commit-bot: I haz the power, 2015-02-03 16:40:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898573002/20001

[commit-bot: I haz the power, 2015-02-03 16:40:10]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-03 22:40 UTC

[djsollen, 2015-02-03 18:22:39]

https://codereview.chromium.org/898573002/diff/20001/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/898573002/diff/20001/samplecode/OverView.cpp#...
samplecode/OverView.cpp:49: return case_insensitive_find(name.c_str(),
filter.c_str());
why not just use strcasecomp or call tolower on both cstrings and use strcmp?

http://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html

[reed1, 2015-02-03 19:53:09]

The CQ bit was checked by reed@google.com

[reed1, 2015-02-03 19:53:16]

ptal

https://codereview.chromium.org/898573002/diff/20001/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/898573002/diff/20001/samplecode/OverView.cpp#...
samplecode/OverView.cpp:49: return case_insensitive_find(name.c_str(),
filter.c_str());
On 2015/02/03 18:22:38, djsollen wrote:
> why not just use strcasecomp or call tolower on both cstrings and use strcmp?
> 
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/strcasecmp.html

slower (due to mallocs) but Done.

[commit-bot: I haz the power, 2015-02-03 19:54:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898573002/40001

[commit-bot: I haz the power, 2015-02-03 19:54:06]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-04 01:54 UTC

[djsollen, 2015-02-03 20:54:22]

lgtm

[commit-bot: I haz the power, 2015-02-03 21:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 21:54:21]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (None)
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (None)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(None)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (None)
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (None)

[reed1, 2015-02-03 22:06:21]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-02-03 22:07:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898573002/40001

[commit-bot: I haz the power, 2015-02-03 23:02:28]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bf015c34e4c36467dfef385893f375b68718450e