Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 898553004: Revert "Fix visible size for V4L2 VDA" (Closed)

Created:
5 years, 10 months ago by ilja
Modified:
5 years, 10 months ago
Reviewers:
hshi1, kcwu, posciak1, ccameron
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix visible size for V4L2 VDA" This reverts commit ad3526512104b5a7352f356b62f8cea3427a58cb. It causes video on peach_pit to lock up/reboot machine. BUG=chromium:449920, chromium:448208 TEST=test_that 100.96.59.64 video_VideoSanity.bvt doesn't reboot anymore Committed: https://crrev.com/f8b95b1bac2582a87f9f67fb3a35413202ecb07f Cr-Commit-Position: refs/heads/master@{#314871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -79 lines) Patch
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 2 chunks +7 lines, -17 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 12 chunks +19 lines, -62 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ilja
This prevented Chrome to roll into CrOS.
5 years, 10 months ago (2015-02-05 20:24:25 UTC) #2
hshi1
On 2015/02/05 20:19:40, ilja wrote: > mailto:ihf@chromium.org changed reviewers: > + mailto:hshi@chromium.org, mailto:kcwu@chromium.org, mailto:posciak@google.com LGTM
5 years, 10 months ago (2015-02-05 20:25:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898553004/1
5 years, 10 months ago (2015-02-05 20:26:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40781)
5 years, 10 months ago (2015-02-05 20:32:40 UTC) #7
ccameron
owner stamp lgtm
5 years, 10 months ago (2015-02-05 20:47:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898553004/1
5 years, 10 months ago (2015-02-05 20:49:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 20:53:09 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 20:55:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8b95b1bac2582a87f9f67fb3a35413202ecb07f
Cr-Commit-Position: refs/heads/master@{#314871}

Powered by Google App Engine
This is Rietveld 408576698