Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/password_manager/core/browser/affiliation_utils_unittest.cc

Issue 898553002: Add flag to enable/disable affiliaton based matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliation_utils_unittest.cc
diff --git a/components/password_manager/core/browser/affiliation_utils_unittest.cc b/components/password_manager/core/browser/affiliation_utils_unittest.cc
index 540963d65761d69c9503cca2f80e33bbbf9c288d..c04aefbe5df50bb9208b07333a4388ec701ceefa 100644
--- a/components/password_manager/core/browser/affiliation_utils_unittest.cc
+++ b/components/password_manager/core/browser/affiliation_utils_unittest.cc
@@ -4,6 +4,10 @@
#include "components/password_manager/core/browser/affiliation_utils.h"
+#include "base/command_line.h"
+#include "base/metrics/field_trial.h"
+#include "components/password_manager/core/common/password_manager_switches.h"
+#include "components/variations/variations_associated_data.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/url_constants.h"
@@ -192,4 +196,48 @@ TEST(AffiliationUtilsTest, NotEqualEquivalenceClasses) {
EXPECT_FALSE(AreEquivalenceClassesEqual(c, b));
}
+TEST(AffiliationUtilsTest, IsAffiliationBasedMatchingEnabled) {
+ const char kFieldTrialName[] = "AffiliationBasedMatching";
+ const char kFieldTrialGroupName[] = "Group";
+
+ struct {
+ const char* variation_param;
+ const char* command_line_switch;
+ bool expected_enabled;
+ } kTestCases[] = {
+ {"", "", false},
+ {"", switches::kEnableAffiliationBasedMatching, true},
+ {"", switches::kDisableAffiliationBasedMatching, false},
+ {"garbage value", "", false},
+ {"false", "", false},
+ {"false", switches::kDisableAffiliationBasedMatching, false},
+ {"false", switches::kEnableAffiliationBasedMatching, true},
+ {"true", switches::kDisableAffiliationBasedMatching, false},
+ {"true", switches::kEnableAffiliationBasedMatching, true}};
+
+ for (const auto& test_case : kTestCases) {
+ SCOPED_TRACE(testing::Message("Command line = ")
+ << test_case.command_line_switch);
+ SCOPED_TRACE(testing::Message("Variation param = ")
+ << test_case.variation_param);
+
+ base::FieldTrialList field_trials(NULL);
+ base::FieldTrialList::CreateFieldTrial(kFieldTrialName,
+ kFieldTrialGroupName);
+
+ std::map<std::string, std::string> variation_params;
+ variation_params["enabled"] = test_case.variation_param;
+ ASSERT_TRUE(variations::AssociateVariationParams(
+ kFieldTrialName, kFieldTrialGroupName, variation_params));
+
+ base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
+ command_line.AppendSwitch(test_case.command_line_switch);
+ EXPECT_EQ(test_case.expected_enabled,
+ IsAffiliationBasedMatchingEnabled(command_line));
+
+ variations::testing::ClearAllVariationIDs();
+ variations::testing::ClearAllVariationParams();
+ }
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698