Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 898543006: ash: Add missing dependency on events_ozone (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Add missing dependency on events_ozone This is needed by display_controller.cc in ozone builds (to set display rotation & scale to apply to cursor movement). These dependencies are needed to enable strict checking of undefined symbols in the shared_library build. BUG=445627 TEST=build chrome for link_freon via simplechrome Committed: https://crrev.com/8da6aa6d5f5d4000fa733df814e83ff57da56dca Cr-Commit-Position: refs/heads/master@{#314429}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ash/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 10 months ago (2015-02-03 21:12:34 UTC) #2
Daniel Erat
https://codereview.chromium.org/898543006/diff/1/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/898543006/diff/1/ash/ash.gyp#newcode937 ash/ash.gyp:937: '../ui/events/ozone/events_ozone.gyp:events_ozone', add this to ash/BUILD.gn too? (looks like it's ...
5 years, 10 months ago (2015-02-03 21:14:52 UTC) #3
spang
On 2015/02/03 21:14:52, Daniel Erat wrote: > https://codereview.chromium.org/898543006/diff/1/ash/ash.gyp > File ash/ash.gyp (right): > > https://codereview.chromium.org/898543006/diff/1/ash/ash.gyp#newcode937 ...
5 years, 10 months ago (2015-02-03 21:32:31 UTC) #4
Daniel Erat
lgtm
5 years, 10 months ago (2015-02-03 21:50:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898543006/20001
5 years, 10 months ago (2015-02-03 21:55:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 23:18:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 23:19:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8da6aa6d5f5d4000fa733df814e83ff57da56dca
Cr-Commit-Position: refs/heads/master@{#314429}

Powered by Google App Engine
This is Rietveld 408576698