Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: ui/gl/gl_fence.cc

Issue 898543002: Remove GLFence::CreateWithoutFlush (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove flush event Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/gl_fence.h ('k') | ui/gl/gl_fence_apple.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_fence.h" 5 #include "ui/gl/gl_fence.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "ui/gl/gl_bindings.h" 8 #include "ui/gl/gl_bindings.h"
9 #include "ui/gl/gl_context.h" 9 #include "ui/gl/gl_context.h"
10 #include "ui/gl/gl_fence_arb.h" 10 #include "ui/gl/gl_fence_arb.h"
11 #include "ui/gl/gl_fence_egl.h" 11 #include "ui/gl/gl_fence_egl.h"
12 #include "ui/gl/gl_fence_nv.h" 12 #include "ui/gl/gl_fence_nv.h"
13 #include "ui/gl/gl_gl_api_implementation.h" 13 #include "ui/gl/gl_gl_api_implementation.h"
14 #include "ui/gl/gl_version_info.h" 14 #include "ui/gl/gl_version_info.h"
15 15
16 #if defined(OS_MACOSX) 16 #if defined(OS_MACOSX)
17 #include "ui/gl/gl_fence_apple.h" 17 #include "ui/gl/gl_fence_apple.h"
18 #endif 18 #endif
19 19
20 namespace gfx { 20 namespace gfx {
21 21
22 namespace {
23
24 // static
25 GLFence* CreateFence(bool flush) {
26 DCHECK(GLContext::GetCurrent())
27 << "Trying to create fence with no context";
28
29 scoped_ptr<GLFence> fence;
30 // Prefer ARB_sync which supports server-side wait.
31 if (g_driver_gl.ext.b_GL_ARB_sync ||
32 GetGLVersionInfo()->is_es3) {
33 fence.reset(new GLFenceARB(flush));
34 #if defined(OS_MACOSX)
35 } else if (g_driver_gl.ext.b_GL_APPLE_fence) {
36 fence.reset(new GLFenceAPPLE(flush));
37 #else
38 } else if (g_driver_egl.ext.b_EGL_KHR_fence_sync) {
39 fence.reset(new GLFenceEGL(flush));
40 #endif
41 } else if (g_driver_gl.ext.b_GL_NV_fence) {
42 fence.reset(new GLFenceNV(flush));
43 }
44
45 DCHECK_EQ(!!fence.get(), GLFence::IsSupported());
46 return fence.release();
47 }
48
49 } // namespace
50
51 GLFence::GLFence() { 22 GLFence::GLFence() {
52 } 23 }
53 24
54 GLFence::~GLFence() { 25 GLFence::~GLFence() {
55 } 26 }
56 27
57 bool GLFence::IsSupported() { 28 bool GLFence::IsSupported() {
58 DCHECK(GetGLVersionInfo()); 29 DCHECK(GetGLVersionInfo());
59 return g_driver_gl.ext.b_GL_ARB_sync || GetGLVersionInfo()->is_es3 || 30 return g_driver_gl.ext.b_GL_ARB_sync || GetGLVersionInfo()->is_es3 ||
60 #if defined(OS_MACOSX) 31 #if defined(OS_MACOSX)
61 g_driver_gl.ext.b_GL_APPLE_fence || 32 g_driver_gl.ext.b_GL_APPLE_fence ||
62 #else 33 #else
63 g_driver_egl.ext.b_EGL_KHR_fence_sync || 34 g_driver_egl.ext.b_EGL_KHR_fence_sync ||
64 #endif 35 #endif
65 g_driver_gl.ext.b_GL_NV_fence; 36 g_driver_gl.ext.b_GL_NV_fence;
66 } 37 }
67 38
68 GLFence* GLFence::Create() { 39 GLFence* GLFence::Create() {
69 return CreateFence(true); 40 DCHECK(GLContext::GetCurrent())
70 } 41 << "Trying to create fence with no context";
71 42
72 GLFence* GLFence::CreateWithoutFlush() { 43 scoped_ptr<GLFence> fence;
73 return CreateFence(false); 44 // Prefer ARB_sync which supports server-side wait.
45 if (g_driver_gl.ext.b_GL_ARB_sync ||
46 GetGLVersionInfo()->is_es3) {
47 fence.reset(new GLFenceARB);
48 #if defined(OS_MACOSX)
49 } else if (g_driver_gl.ext.b_GL_APPLE_fence) {
50 fence.reset(new GLFenceAPPLE);
51 #else
52 } else if (g_driver_egl.ext.b_EGL_KHR_fence_sync) {
53 fence.reset(new GLFenceEGL);
54 #endif
55 } else if (g_driver_gl.ext.b_GL_NV_fence) {
56 fence.reset(new GLFenceNV);
57 }
58
59 DCHECK_EQ(!!fence.get(), GLFence::IsSupported());
60 return fence.release();
74 } 61 }
75 62
76 } // namespace gfx 63 } // namespace gfx
OLDNEW
« no previous file with comments | « ui/gl/gl_fence.h ('k') | ui/gl/gl_fence_apple.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698