Rename for some supervised users ambiguity. Adding child account icon to the avatar menu bubble.

Rename for some supervised users ambiguity. Adding child account icon to the avatar menu bubble.

BUG=440359
TBR=rsesek@chromium.org, noms@chromium.org, oshima@chromium.org

Committed: https://crrev.com/109d2339552df1c5ebff8a6174f983cd21390e34
Cr-Commit-Position: refs/heads/master@{#315318}

[merkulova, 2015-02-05 11:38:20]

merkulova@chromium.org changed reviewers:
+ treib@chromium.org

[merkulova, 2015-02-05 11:38:48]

Marc, please, take a look.

[Marc Treib, 2015-02-05 12:24:10]

On 2015/02/05 11:38:48, merkulova wrote:
> Marc, please, take a look.

LGTM, thanks! (I don't own anything here though)

[Marc Treib, 2015-02-05 12:25:06]

You can link crbug.com/440359 :)

https://codereview.chromium.org/898533005/diff/1/chrome/browser/profiles/avat...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/898533005/diff/1/chrome/browser/profiles/avat...
chrome/browser/profiles/avatar_menu.cc:228: if (browser_ &&
browser_->profile()->IsChild())
nit: Add braces for multiline "if" body.

This is the old avatar menu, right? We've decided not to bother updating that
for child accounts, since it's been (mostly) replaced by the new one already. Of
course it's still fine to do this change here, but in the future, you don't need
to worry about the old avatar menu :)

[merkulova, 2015-02-05 12:32:55]

New patchsets have been uploaded after l-g-t-m from treib@chromium.org

[merkulova, 2015-02-05 12:40:15]

merkulova@chromium.org changed reviewers:
+ nkostylev@chromium.org

[merkulova, 2015-02-05 12:41:11]

https://codereview.chromium.org/898533005/diff/1/chrome/browser/profiles/avat...
File chrome/browser/profiles/avatar_menu.cc (right):

https://codereview.chromium.org/898533005/diff/1/chrome/browser/profiles/avat...
chrome/browser/profiles/avatar_menu.cc:228: if (browser_ &&
browser_->profile()->IsChild())
On 2015/02/05 12:25:06, Marc Treib wrote:
> nit: Add braces for multiline "if" body.
> 
> This is the old avatar menu, right? We've decided not to bother updating that
> for child accounts, since it's been (mostly) replaced by the new one already.
Of
> course it's still fine to do this change here, but in the future, you don't
need
> to worry about the old avatar menu :)

Added braces. Ok, thanks)

[Nikita (slow), 2015-02-05 13:23:42]

lgtm

https://codereview.chromium.org/898533005/diff/20001/ui/login/account_picker/...
File ui/login/account_picker/user_pod_row.css (right):

https://codereview.chromium.org/898533005/diff/20001/ui/login/account_picker/...
ui/login/account_picker/user_pod_row.css:429: .user-type-icon-area.supervised
.user-type-icon-image {
legacySupervised

[merkulova, 2015-02-05 16:25:12]

New patchsets have been uploaded after l-g-t-m from nkostylev@chromium.org

[merkulova, 2015-02-05 16:25:29]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2015-02-05 16:25:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898533005/40001

[commit-bot: I haz the power, 2015-02-05 17:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 17:31:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[merkulova, 2015-02-09 08:28:31]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2015-02-09 08:29:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898533005/60001

[commit-bot: I haz the power, 2015-02-09 09:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 09:09:07]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[merkulova, 2015-02-09 14:19:11]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2015-02-09 14:20:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898533005/60001

[commit-bot: I haz the power, 2015-02-09 16:14:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-09 16:15:20]

Patchset 4 (id:??) landed as
https://crrev.com/109d2339552df1c5ebff8a6174f983cd21390e34
Cr-Commit-Position: refs/heads/master@{#315318}