Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 898533003: Files.app: Add createSnapshot, clone, hasFreashCache methods to metadata models. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add createSnapshot, clone, hasFreashCache methods to metadata models. The CL: * Adds createSnapshot and hasFreshCache methods to MetadataCacheSet * Adds clone and hasFreshCache mehtods to MetadataCacheItem The createSnapshot and clone are the methods to generage deep copy of the model. The hasFreshCache is the method to check the cache contains all required caches. BUG=410766 TEST=FileManagerJsTest.MetadataCacheSet,FileManagerJsTest.MetadataCacheItem Committed: https://crrev.com/c69d6c6efff672ca757217d73746b9c8f87cb4d8 Cr-Commit-Position: refs/heads/master@{#314259}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js View 1 1 chunk +32 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 1 chunk +30 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-03 00:31:13 UTC) #2
yawano
lgtm.
5 years, 10 months ago (2015-02-03 01:26:08 UTC) #3
hirono
On 2015/02/03 01:26:08, yawano wrote: > lgtm. Thanks!
5 years, 10 months ago (2015-02-03 01:30:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898533003/20001
5 years, 10 months ago (2015-02-03 01:30:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 02:31:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898533003/20001
5 years, 10 months ago (2015-02-03 03:22:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 03:26:36 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 03:28:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c69d6c6efff672ca757217d73746b9c8f87cb4d8
Cr-Commit-Position: refs/heads/master@{#314259}

Powered by Google App Engine
This is Rietveld 408576698