Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: remoting/base/decoder.h

Issue 8985007: Refactoring of the client-side input pipeline and scaling dimension management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/base/decoder_vp8.h » ('j') | remoting/base/decoder_vp8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/decoder.h
diff --git a/remoting/base/decoder.h b/remoting/base/decoder.h
index d932ff15c3aaab206506bf54e33feb08c5028161..dd377570b5215b4c09953318bb7d705213a4957a 100644
--- a/remoting/base/decoder.h
+++ b/remoting/base/decoder.h
@@ -57,11 +57,10 @@ class Decoder {
virtual VideoPacketFormat::Encoding Encoding() = 0;
- // Set the scale factors of the decoded output. If the decoder doesn't support
- // scaling then this all is ignored.
- // If both |horizontal_ratio| and |vertical_ratio| equal 1.0 then scaling is
- // turned off.
- virtual void SetScaleRatios(double horizontal_ratio, double vertical_ratio) {}
+ // Set the output dimensions for the decoder. If the dimensions are empty
+ // then the source is rendered without scaling.
+ // Output dimensions are ignored if the decoder doesn't support scaling.
+ virtual void SetOutputSize(const SkISize& size) {}
// Set the clipping rectangle to the decoder. Decoder should respect this and
// only output changes in this rectangle. The new clipping rectangle will be
@@ -71,9 +70,8 @@ class Decoder {
virtual void SetClipRect(const SkIRect& clip_rect) {}
// Force decoder to output a video frame with content in |rects| using the
- // last decoded video frame.
- //
- // Coordinates of rectangles supplied here are before scaling.
+ // last decoded video frame. |rects| are expressed in video frame rather
+ // than output coordinates.
virtual void RefreshRects(const RectVector& rects) {}
};
« no previous file with comments | « no previous file | remoting/base/decoder_vp8.h » ('j') | remoting/base/decoder_vp8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698