Issue 898493003: Pass the size of the array to GetModuleFileName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898493003: Pass the size of the array to GetModuleFileName. (Closed)

Created:
5 years, 10 months ago by rickyz (no longer on Chrome)

Modified:
5 years, 10 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pass the size of the array to GetModuleFileName. TCHAR may be a WCHAR, so sizeof would allow GetModuleFileName to write twice the size of the buffer. Thanks to Ilya Berdichevsky for the bug and fix. BUG=446464 Committed: https://crrev.com/487353e4abfc8902439be6aed288adcfb9ece9e3 Cr-Commit-Position: refs/heads/master@{#314223}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/browser/accessibility/browser_accessibility_state_impl_win.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898493003/1

5 years, 10 months ago (2015-02-02 22:38:36 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-03 00:34:14 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/487353e4abfc8902439be6aed288adcfb9ece9e3
Cr-Commit-Position: refs/heads/master@{#314223}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages