Upstream SmoothProgressBar and ToolbarProgressBar

Upstream SmoothProgressBar and ToolbarProgressBar

BUG=453188
Committed: https://crrev.com/92f0b13b71d683c281bc99fec329c3bcc3fcfe17
Cr-Commit-Position: refs/heads/master@{#314654}

[Jaekyun Seok (inactive), 2015-02-03 01:34:23]

jaekyun@chromium.org changed reviewers:
+ changwan@chromium.org, dtrainor@chromium.org, kkimlabs@chromium.org

[Jaekyun Seok (inactive), 2015-02-03 01:34:24]

Please review this CL.

[Kibeom Kim (inactive), 2015-02-03 19:10:21]

lgtm

(I'm not OWNER)

https://codereview.chromium.org/898483006/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java
(right):

https://codereview.chromium.org/898483006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java:32:
private int mResolutionMutiplier = 1;
just fyi: we don't actually need mResolutionMutiplier variable since we're not
animating now.

[Jaekyun Seok (inactive), 2015-02-03 21:47:04]

https://codereview.chromium.org/898483006/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java
(right):

https://codereview.chromium.org/898483006/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java:32:
private int mResolutionMutiplier = 1;
On 2015/02/03 19:10:21, Kibeom Kim wrote:
> just fyi: we don't actually need mResolutionMutiplier variable since we're not
> animating now.

Right, but I think that we can clean up later when we decide that after some
trials to turn on the animation.

[David Trainor- moved to gerrit, 2015-02-03 22:21:18]

lgtm

I have another patch going through the CQ right now (it failed due to a separate
existing issue on the branch).  It should land soon.  You might want to roll
that into this as well if that lands.

[David Trainor- moved to gerrit, 2015-02-03 22:21:47]

On 2015/02/03 22:21:18, David Trainor wrote:
> lgtm
> 
> I have another patch going through the CQ right now (it failed due to a
separate
> existing issue on the branch).  It should land soon.  You might want to roll
> that into this as well if that lands.

Oh actually, as I mentioned in the comment, let's make ChromeShell use this so
that something is using the code upstream.  That way we can upstream relevant
unit tests.

[Jaekyun Seok (inactive), 2015-02-04 00:49:49]

New patchsets have been uploaded after l-g-t-m from dtrainor@chromium.org

[Jaekyun Seok (inactive), 2015-02-04 00:51:58]

On 2015/02/03 22:21:47, David Trainor wrote:
> On 2015/02/03 22:21:18, David Trainor wrote:
> > lgtm
> > 
> > I have another patch going through the CQ right now (it failed due to a
> separate
> > existing issue on the branch).  It should land soon.  You might want to roll
> > that into this as well if that lands.
> 
> Oh actually, as I mentioned in the comment, let's make ChromeShell use this so
> that something is using the code upstream.  That way we can upstream relevant
> unit tests.

PTAL.

I've merged https://chrome-internal-review.googlesource.com/195277 into this CL.

BTW, I'm not sure whether UX of a new progress bar is acceptable or not. You can
see it in
https://drive.google.com/a/google.com/file/d/0B0rlutRlVuQKVzVBMFdJSVBRekE/vie...
.

[David Trainor- moved to gerrit, 2015-02-04 01:19:53]

lgtm

[Jaekyun Seok (inactive), 2015-02-04 07:13:55]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2015-02-04 07:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898483006/40001

[Jaekyun Seok (inactive), 2015-02-04 07:47:29]

The CQ bit was unchecked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-02-04 08:20:14]

New patchsets have been uploaded after l-g-t-m from dtrainor@chromium.org

[Jaekyun Seok (inactive), 2015-02-04 08:22:10]

PTAL.

I've merged https://chrome-internal-review.googlesource.com/195525 into this CL
to fix failures of findbugs.

[David Trainor- moved to gerrit, 2015-02-04 19:40:22]

lgtm

[David Trainor- moved to gerrit, 2015-02-04 19:40:35]

Thanks for merging that for me!

[Jaekyun Seok (inactive), 2015-02-04 21:27:33]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898483006/60001

[commit-bot: I haz the power, 2015-02-04 21:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:32:32]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Jaekyun Seok (inactive), 2015-02-04 21:46:39]

New patchsets have been uploaded after l-g-t-m from dtrainor@chromium.org

[Jaekyun Seok (inactive), 2015-02-04 21:47:53]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:49:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898483006/80001

[commit-bot: I haz the power, 2015-02-04 22:12:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-04 22:13:50]

Patchset 5 (id:??) landed as
https://crrev.com/92f0b13b71d683c281bc99fec329c3bcc3fcfe17
Cr-Commit-Position: refs/heads/master@{#314654}