Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 898473003: Revert of Remove dependency of HistoryService on WebHistoryServiceFactory (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@schedule-and-forget
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove dependency of HistoryService on WebHistoryServiceFactory (patchset #2 id:20001 of https://codereview.chromium.org/891763002/) Reason for revert: BUG=454524 Original issue's description: > Remove dependency of HistoryService on WebHistoryServiceFactory > > Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to > receive the history::WebHistoryService instance to use in order > to remove a dependency of HistoryService on Profile. > > It is not possible to pass the WebHistoryService instance to the > HistoryService constructor and add a dependency between the two > factories due to http://crbug.com/171406 (as WebHistoryService > depends on a KeyedService calling Profile::GetRequestContext()). > > BUG=453790 > R=droger@chromium.org > > Committed: https://crrev.com/173da8215285a28458517ae5423f4ff23c8223cd > Cr-Commit-Position: refs/heads/master@{#314152} TBR=droger@chromium.org,bauerb@chromium.org,sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453790 Committed: https://crrev.com/da344b86e26e68600abadce720ca9008351b862d Cr-Commit-Position: refs/heads/master@{#314216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/history/history_service.h View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/history/history_service.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vitaly Buka (NO REVIEWS)
Created Revert of Remove dependency of HistoryService on WebHistoryServiceFactory
5 years, 10 months ago (2015-02-02 23:09:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898473003/1
5 years, 10 months ago (2015-02-02 23:10:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 23:12:07 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 23:12:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da344b86e26e68600abadce720ca9008351b862d
Cr-Commit-Position: refs/heads/master@{#314216}

Powered by Google App Engine
This is Rietveld 408576698