DescriptionRevert of Remove dependency of HistoryService on WebHistoryServiceFactory (patchset #2 id:20001 of https://codereview.chromium.org/891763002/)
Reason for revert:
BUG=454524
Original issue's description:
> Remove dependency of HistoryService on WebHistoryServiceFactory
>
> Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to
> receive the history::WebHistoryService instance to use in order
> to remove a dependency of HistoryService on Profile.
>
> It is not possible to pass the WebHistoryService instance to the
> HistoryService constructor and add a dependency between the two
> factories due to http://crbug.com/171406 (as WebHistoryService
> depends on a KeyedService calling Profile::GetRequestContext()).
>
> BUG=453790
> R=droger@chromium.org
>
> Committed: https://crrev.com/173da8215285a28458517ae5423f4ff23c8223cd
> Cr-Commit-Position: refs/heads/master@{#314152}
TBR=droger@chromium.org,bauerb@chromium.org,sdefresne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453790
Committed: https://crrev.com/da344b86e26e68600abadce720ca9008351b862d
Cr-Commit-Position: refs/heads/master@{#314216}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|