pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart - Issue 898463002: Rename ClosureVariable, use separate IR forms for declaration and assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 898463002: Rename ClosureVariable, use separate IR forms for declaration and assignment. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('K') | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | tests/compiler/dart2js/backend_dart/sexpr_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

index ab74fa17bcd62ff57d3be0424d17905557dcfbfa..a46ea05dd66d909dca357e1da6070bfc785f336d 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

@@ -494,7 +494,7 @@ class Assign extends Statement {

Expression definition;

/// If true, this declares a new copy of the closure variable.

asgerf 2015/02/03 10:27:31 "closure variable" -> "variable"

Kevin Millikin (Google) 2015/02/03 14:11:49 Done. Actually, the second part of the comment do

- /// The consequences are similar to [cps_ir.SetClosureVariable].

+ /// The consequences are similar to [cps_ir.SetMutableVariable].

/// All uses of the variable must be nested inside the [next] statement.

bool isDeclaration;