Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 898453003: Add resourcePath to running dm on Android doc. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add resourcePath to running dm on Android doc. Without specifying the resource path a number of tests and gms do not work properly. The example given in the docs should specify the resource path so that the example run is exemplary. Committed: https://skia.googlesource.com/skia/+/db204e301b1320af242e1be5e477cd9453b126a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M site/user/quick/android.md View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
Magic preview at https://skia.org/user/quick/android?cl=898453003 .
5 years, 10 months ago (2015-02-02 17:14:51 UTC) #2
mtklein
lgtm
5 years, 10 months ago (2015-02-02 17:19:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898453003/1
5 years, 10 months ago (2015-02-02 17:20:21 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 17:27:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/db204e301b1320af242e1be5e477cd9453b126a6

Powered by Google App Engine
This is Rietveld 408576698