Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 898443004: Adds "tts" permission for Input Tools & XKB extension. (Closed)

Created:
5 years, 10 months ago by wuyingbing1
Modified:
5 years, 10 months ago
Reviewers:
Shu Chen, FengYuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds "tts" permission for Input Tools & XKB extension. BUG=422869 Committed: https://crrev.com/3e7d9ac1e06a56f3847d213a4a1b7d6de340778d Cr-Commit-Position: refs/heads/master@{#314286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wuyingbing1
Adds tts permission.
5 years, 10 months ago (2015-02-03 06:25:33 UTC) #2
Shu Chen
lgtm
5 years, 10 months ago (2015-02-03 06:27:57 UTC) #3
FengYuan
lgtm
5 years, 10 months ago (2015-02-03 07:10:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898443004/1
5 years, 10 months ago (2015-02-03 07:11:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 07:47:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 07:48:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e7d9ac1e06a56f3847d213a4a1b7d6de340778d
Cr-Commit-Position: refs/heads/master@{#314286}

Powered by Google App Engine
This is Rietveld 408576698